You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ricky Saltzer (JIRA)" <ji...@apache.org> on 2012/10/10 23:41:04 UTC

[jira] [Created] (HBASE-6972) HBase Shell deleteall requires column to be defined

Ricky Saltzer created HBASE-6972:
------------------------------------

             Summary: HBase Shell deleteall requires column to be defined 
                 Key: HBASE-6972
                 URL: https://issues.apache.org/jira/browse/HBASE-6972
             Project: HBase
          Issue Type: Bug
          Components: shell
            Reporter: Ricky Saltzer


It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 

I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ricky Saltzer updated HBASE-6972:
---------------------------------

    Attachment:     (was: HBASE-6972.patch)
    
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.patch, HBASE-6972.patch.v2
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6972) HBase Shell deleteall should not require column to be defined

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481946#comment-13481946 ] 

Hudson commented on HBASE-6972:
-------------------------------

Integrated in HBase-TRUNK #3473 (See [https://builds.apache.org/job/HBase-TRUNK/3473/])
    HBASE-6972 HBase Shell deleteall should not require column to be defined (Ricky) (Revision 1401115)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/hbase-server/src/main/ruby/shell/commands/deleteall.rb

                
> HBase Shell deleteall should not require column to be defined 
> --------------------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.2.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "David S. Wang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481877#comment-13481877 ] 

David S. Wang commented on HBASE-6972:
--------------------------------------

+1 on patch.
                
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.2.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ricky Saltzer updated HBASE-6972:
---------------------------------

    Attachment: HBASE-6972.patch

This patch makes the column optional when calling *deleteall*. This allows for users to delete an entire row, rather than specifying each column they want to delete. This was originally how the command worked, but somewhere down the line it was changed. 
                
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Ricky Saltzer
>         Attachments: HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall should not require column to be defined

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-6972:
--------------------------

    Summary: HBase Shell deleteall should not require column to be defined   (was: HBase Shell deleteall requires column to be defined )
    
> HBase Shell deleteall should not require column to be defined 
> --------------------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.2.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ricky Saltzer updated HBASE-6972:
---------------------------------

    Attachment: HBASE-6972.2.patch
    
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.2.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6972) HBase Shell deleteall should not require column to be defined

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481966#comment-13481966 ] 

Hudson commented on HBASE-6972:
-------------------------------

Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #231 (See [https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/231/])
    HBASE-6972 HBase Shell deleteall should not require column to be defined (Ricky) (Revision 1401115)

     Result = FAILURE
tedyu : 
Files : 
* /hbase/trunk/hbase-server/src/main/ruby/shell/commands/deleteall.rb

                
> HBase Shell deleteall should not require column to be defined 
> --------------------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.2.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ricky Saltzer updated HBASE-6972:
---------------------------------

    Attachment: HBASE-6972.patch.v2
    
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.patch, HBASE-6972.patch.v2
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall should not require column to be defined

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-6972:
--------------------------

      Resolution: Fixed
    Hadoop Flags: Reviewed
          Status: Resolved  (was: Patch Available)
    
> HBase Shell deleteall should not require column to be defined 
> --------------------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.2.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473638#comment-13473638 ] 

Hadoop QA commented on HBASE-6972:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548640/HBASE-6972.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 81 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       org.apache.hadoop.hbase.master.TestSplitLogManager

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3028//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3028//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3028//console

This message is automatically generated.
                
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ricky Saltzer updated HBASE-6972:
---------------------------------

    Attachment:     (was: HBASE-6972.patch.v2)
    
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.2.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473592#comment-13473592 ] 

Ricky Saltzer commented on HBASE-6972:
--------------------------------------

*After Patch*

Works as intended

{noformat}
hbase(main):004:0> deleteall 'test', 'row2'
0 row(s) in 0.0190 seconds
{noformat}
                
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Ricky Saltzer
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ricky Saltzer updated HBASE-6972:
---------------------------------

    Assignee: Ricky Saltzer
    
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>         Attachments: HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ricky Saltzer updated HBASE-6972:
---------------------------------

    Attachment: HBASE-6972.patch

Per Ted's suggestion, I'm uploading a second version of the patch which breaks up the method into two lines due to the length. 
                
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473862#comment-13473862 ] 

Hadoop QA commented on HBASE-6972:
----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12548694/HBASE-6972.2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 hadoop2.0{color}.  The patch compiles against the hadoop 2.0 profile.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 81 warning messages.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 findbugs{color}.  The patch appears to introduce 5 new Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/3031//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3031//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3031//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop1-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3031//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3031//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/3031//artifact/trunk/patchprocess/newPatchFindbugsWarningshbase-server.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/3031//console

This message is automatically generated.
                
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.2.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ricky Saltzer updated HBASE-6972:
---------------------------------

        Fix Version/s: 0.96.0
    Affects Version/s: 0.96.0
               Status: Patch Available  (was: Open)

This patch makes the column optional when calling deleteall. This allows for users to delete an entire row, rather than specifying each column they want to delete. This was originally how the command worked, but somewhere down the line it was changed.

I've tested this in standalone and it seems to work. 
                
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6972) HBase Shell deleteall should not require column to be defined

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13481901#comment-13481901 ] 

Ted Yu commented on HBASE-6972:
-------------------------------

Integrated to trunk.

Thanks for the patch, Ricky.

Thanks for the review, David.
                
> HBase Shell deleteall should not require column to be defined 
> --------------------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.2.patch, HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ricky Saltzer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473591#comment-13473591 ] 

Ricky Saltzer commented on HBASE-6972:
--------------------------------------

Here's a sample of the issue...

*Intention*: Delete entire row
---
*Table*: test
*Row*: row2

{noformat}
hbase(main):008:0> deleteall 'test', 'row2'

ERROR: wrong number of arguments (2 for 3)

Here is some help for this command:
Delete all cells in a given row; pass a table name, row, and optionally
a column and timestamp. Examples:

  hbase> deleteall 't1', 'r1'
  hbase> deleteall 't1', 'r1', 'c1'
  hbase> deleteall 't1', 'r1', 'c1', ts1

The same commands also can be run on a table reference. Suppose you had a reference
t to table 't1', the corresponding command would be:

  hbase> t.deleteall 'r1'
  hbase> t.deleteall 'r1', 'c1'
  hbase> t.deleteall 'r1', 'c1', ts1
{noformat}
                
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>            Reporter: Ricky Saltzer
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HBASE-6972) HBase Shell deleteall requires column to be defined

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473662#comment-13473662 ] 

Ted Yu commented on HBASE-6972:
-------------------------------

Patch looks good.
nit:
{code}
+      def command(table, row, column = nil, timestamp = org.apache.hadoop.hbase.HConstants::LATEST_TIMESTAMP)
{code}
It would nice to wrap the above long line.
                
> HBase Shell deleteall requires column to be defined 
> ----------------------------------------------------
>
>                 Key: HBASE-6972
>                 URL: https://issues.apache.org/jira/browse/HBASE-6972
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 0.96.0
>            Reporter: Ricky Saltzer
>            Assignee: Ricky Saltzer
>             Fix For: 0.96.0
>
>         Attachments: HBASE-6972.patch
>
>
> It appears that the shell does not allow users to delete a row without specifying a column (deleteall). It looks like the deleteall.rb used to pre-define column as nil, making it optional. 
> I've created a patch and confirmed it to be working in standalone mode, I will upload it shortly. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira