You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by "jbertram (via GitHub)" <gi...@apache.org> on 2023/08/22 15:17:28 UTC
[GitHub] [activemq-artemis] jbertram opened a new pull request, #4586: ARTEMIS-4396 make 'internal' address/queue prop durable
jbertram opened a new pull request, #4586:
URL: https://github.com/apache/activemq-artemis/pull/4586
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] jbertram commented on a diff in pull request #4586: ARTEMIS-4396 improve support for 'internal' address/queue prop
Posted by "jbertram (via GitHub)" <gi...@apache.org>.
jbertram commented on code in PR #4586:
URL: https://github.com/apache/activemq-artemis/pull/4586#discussion_r1309111781
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateQueueMessage_V2.java:
##########
@@ -450,6 +468,9 @@ public void decodeRest(final ActiveMQBuffer buffer) {
if (buffer.readableBytes() > 0) {
groupRebalancePauseDispatch = BufferHelper.readNullableBoolean(buffer);
}
+ if (buffer.readableBytes() > 0) {
+ internal = BufferHelper.readNullableBoolean(buffer);
+ }
Review Comment:
After thinking about this some more I'm going in a different direction. Thanks for the feedback!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr merged pull request #4586: ARTEMIS-4396 make address/queue internal prop durable
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr merged PR #4586:
URL: https://github.com/apache/activemq-artemis/pull/4586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] gemmellr commented on a diff in pull request #4586: ARTEMIS-4396 improve support for 'internal' address/queue prop
Posted by "gemmellr (via GitHub)" <gi...@apache.org>.
gemmellr commented on code in PR #4586:
URL: https://github.com/apache/activemq-artemis/pull/4586#discussion_r1307133455
##########
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/CreateQueueMessage_V2.java:
##########
@@ -450,6 +468,9 @@ public void decodeRest(final ActiveMQBuffer buffer) {
if (buffer.readableBytes() > 0) {
groupRebalancePauseDispatch = BufferHelper.readNullableBoolean(buffer);
}
+ if (buffer.readableBytes() > 0) {
+ internal = BufferHelper.readNullableBoolean(buffer);
+ }
Review Comment:
Should it be possible for clients to remotely create 'internal' queues? I don't really see why we would want/need that to be possible now at this point when it hasnt been before? Also, is there any kind of access control needed on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org