You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openoffice.apache.org by bu...@apache.org on 2013/12/07 17:20:09 UTC
[Bug 123812] New: File - Versions - Always save a version on closing
is not working
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Bug ID: 123812
Issue Type: DEFECT
Summary: File - Versions - Always save a version on closing is
not working
Product: Writer
Version: 4.0.1
Hardware: All
OS: All
Status: CONFIRMED
Keywords: regression
Severity: normal
Priority: P3
Component: save-export
Assignee: issues@openoffice.apache.org
Reporter: pescetti@apache.org
CC: issues@openoffice.apache.org
This is a regression with respect to at least 3.3.0; reported on the users list
by user LG.
1. Start Writer, new document, write "aaa", save as test.odt
2. File - Versions, click "Save new version" (and enter a comment), then enable
"Always save a version on closing". Close the dialog.
3. Write "bbb", close OpenOffice, confirm you want to save changes.
4. Reopen the file.
Expected behavior: changes are saved and a new version is created (so
File-Versions shows two versions: the manually saved one and the one
automatically created on closing).
Actual behavior: changes are saved, but a new version is NOT created.
File-Versions only shows the manually saved version.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
--- Comment #16 from SVN Robot <sv...@dev.null.org> ---
"orw" committed SVN revision 1608376 into trunk:
123812: <SfxBaseModel::storeSelf(..)> - accept arguement FailOnWarning in
ord...
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
4.1.1_release_blocker requested: [Issue 123812] File - Versions -
Always save a version on closing is not working
Posted by bu...@apache.org.
Andrea Pescetti <pe...@apache.org> has asked for 4.1.1_release_blocker:
Issue 123812: File - Versions - Always save a version on closing is not working
https://issues.apache.org/ooo/show_bug.cgi?id=123812
------- Additional Comments from Andrea Pescetti <pe...@apache.org>
Nominating as 4.1.1 release blocker: simple patch by hanya available, works for
me, fixes a regression. Should be reviewed and applied both to trunk and AOO410
for OpenOffice 4.1.1.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
--- Comment #17 from SVN Robot <sv...@dev.null.org> ---
"orw" committed SVN revision 1608384 into branches/AOO410:
123812: <SfxBaseModel::storeSelf(..)> - accept arguement FailOnWarning in
ord...
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|4.0.1 |3.4.0
--- Comment #3 from Oliver-Rainer Wittmann <or...@apache.org> ---
I was able to reproduce the described defect on Windows 7 using OOo 3.2.0 and
OOo 3.3.0. It worked in OOo 2.2.0.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jsc@apache.org
Flags|4.1.1_release_blocker? |4.1.1_release_blocker+
--- Comment #13 from jsc@apache.org ---
grant showstopper flag
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |4.1.1_release_blocker?
--- Comment #9 from Andrea Pescetti <pe...@apache.org> ---
Nominating as 4.1.1 release blocker: simple patch by hanya available, works for
me, fixes a regression. Should be reviewed and applied both to trunk and AOO410
for OpenOffice 4.1.1.
--
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
fanyuzhen@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |VERIFIED
CC| |fanyuzhen@gmail.com
--- Comment #19 from fanyuzhen@gmail.com ---
It's verified fixed in build AOO411m2(Build:9771) - Rev. 1608452
2014-07-07 15:29:02 (Mon, 07 Jul 2014)
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
brinzing <ol...@gmx.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oliver.brinzing@gmx.de
--- Comment #2 from brinzing <ol...@gmx.de> ---
.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
--- Comment #8 from Andrea Pescetti <pe...@apache.org> ---
Nominating as 4.1.1 release blocker: simple patch by hanya available, works for
me, fixes a regression. Should be reviewed and applied both to trunk and AOO410
for OpenOffice 4.1.1.
--
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ACCEPTED |RESOLVED
Resolution|--- |FIXED
--- Comment #18 from Oliver-Rainer Wittmann <or...@apache.org> ---
fixed on trunk and on branch AOO410
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |orw@apache.org
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
review granted: [Issue 123812] File - Versions - Always save a
version on closing is not working : [Attachment 82403] Patch to add
FailOnWarning as valid parameter
Posted by bu...@apache.org.
Oliver-Rainer Wittmann <or...@apache.org> has granted review:
Issue 123812: File - Versions - Always save a version on closing is not working
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Attachment 82403: Patch to add FailOnWarning as valid parameter
https://issues.apache.org/ooo/attachment.cgi?id=82403&action=edit
------- Additional Comments from Oliver-Rainer Wittmann <or...@apache.org>
patch looks fine.
@hanya: Do you want to commit the patch by yourself?
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82403| |review+
Flags| |
--- Comment #11 from Oliver-Rainer Wittmann <or...@apache.org> ---
Comment on attachment 82403
--> https://issues.apache.org/ooo/attachment.cgi?id=82403
Patch to add FailOnWarning as valid parameter
patch looks fine.
@hanya: Do you want to commit the patch by yourself?
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|orw@apache.org |hanya.runo@gmail.com
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
oooforum <oo...@free.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oooforum@free.fr
--- Comment #7 from oooforum <oo...@free.fr> ---
(In reply to Andrea Pescetti from comment #5)
> - Closing after making changes and saving them with CTRL+S -> The "Do you
> want to save your changes?" dialog does not appear (and this is normal), but
> I would expect a new version to be saved here too (it doesn't in 4.0.1 and
> it still doesn't with your patch)
Agree with hanya, this should be an enhancement.
In the meantime, is it possible to integrate this patch for the next build?
--
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.
4.1.1_release_blocker granted: [Issue 123812] File - Versions -
Always save a version on closing is not working
Posted by bu...@apache.org.
jsc@apache.org has granted Andrea Pescetti <pe...@apache.org>'s request for
4.1.1_release_blocker:
Issue 123812: File - Versions - Always save a version on closing is not working
https://issues.apache.org/ooo/show_bug.cgi?id=123812
------- Additional Comments from jsc@apache.org
grant showstopper flag
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Pedro <pe...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pedlino@gmail.com
--- Comment #20 from Pedro <pe...@gmail.com> ---
This bug is NOT fixed in RC1. If you reopen each Version you will notice that
the manually saved Version 1 contains the same as Version 2 (i.e. Aaa bbb) when
it should contain only aaa.
Opening a Version does NOT open in Read Only mode.
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Edwin Sharp <el...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |elish@apache.org
--- Comment #1 from Edwin Sharp <el...@apache.org> ---
Confirmed with
AOO410m1(Build:9750) - Rev. 1548193
2013-12-07_04:10:48 - Rev. 1548790
Debian
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Bug 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Andrea Pescetti <pe...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Latest|--- |4.0.1
Confirmation on| |
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
--- Comment #12 from Oliver-Rainer Wittmann <or...@apache.org> ---
I have no objections to include the fix also in our planned 4.1.1 release.
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
--- Comment #5 from Andrea Pescetti <pe...@apache.org> ---
Thanks hanya, I applied (in my local copy) the patch to the current trunk. It
works but not in all cases.
Namely:
- Manual "Save new version" button -> still works
- Closing with unsaved changes -> The "Do you want to save your changes?"
dialog appears, a new version is saved if I confirm (this is thus fixed by the
patch)
- Closing after making changes and saving them with CTRL+S -> The "Do you want
to save your changes?" dialog does not appear (and this is normal), but I would
expect a new version to be saved here too (it doesn't in 4.0.1 and it still
doesn't with your patch)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
--- Comment #23 from Pedro <pe...@gmail.com> ---
This bug is fixed also under Windows. A new Version is indeed created on close.
Opening a new bug report with described problem (which makes Versions useless
under Win7 x64)
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|issues@openoffice.apache.or |orw@apache.org
|g |
--- Comment #10 from Oliver-Rainer Wittmann <or...@apache.org> ---
taking over to review the patch.
--
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
jsc@apache.org changed:
What |Removed |Added
----------------------------------------------------------------------------
Target Milestone|--- |4.1.1
--- Comment #14 from jsc@apache.org ---
set target
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
--- Comment #22 from Ariel Constenla-Haile <ar...@apache.org> ---
Verified fixed on AOO411m4(Build:9774) - Rev. 1614049
2014-07-28 17:55 - Linux x86_64
(In reply to Pedro from comment #20)
> This bug is NOT fixed in RC1. If you reopen each Version you will notice
> that the manually saved Version 1 contains the same as Version 2 (i.e. Aaa
> bbb) when it should contain only aaa.
I cannot reproduce this.
> Opening a Version does NOT open in Read Only mode.
Neither this, the version os opened read-ony.
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
--- Comment #21 from Ariel Constenla-Haile <ar...@apache.org> ---
Strange, on trunk it's working fine
AOO420m1(Build:9800) - Rev. 1614365
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.
[Bug 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
hanya <ha...@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hanya.runo@gmail.com
--- Comment #4 from hanya <ha...@gmail.com> ---
Created attachment 82403
--> https://issues.apache.org/ooo/attachment.cgi?id=82403&action=edit
Patch to add FailOnWarning as valid parameter
If "Always save a version on closing" is checked on Versions dialog,
SID_SAVEDOC request is made with SID_DOCINFO_COMMENTS and
SID_FAIL_ON_WARNING in SfxObjectShell::PrepareClose method.
The SID_SAVEDOC request is processed in SfxObjectShell::ExecFile_Impl method
and
GUIStoreModel method on SfxStoringHelper method is called.
SfxBaseModel::storeSelf method is called to store into the file but
I get IllegalArgumentException and store method is called to store
alternatively.
So, no original arguments for saveas command lost.
The exception is raised because FailOnWarning parameter is not accepted in
storeSelf method.
Storing a version from Versions dialog does not specify FailOnWarning
parameter,
the same problem does not happen with it.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.
You are watching all bug changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
--- Comment #6 from hanya <ha...@gmail.com> ---
(In reply to Andrea Pescetti from comment #5)
> - Closing after making changes and saving them with CTRL+S -> The "Do you
> want to save your changes?" dialog does not appear (and this is normal), but
> I would expect a new version to be saved here too (it doesn't in 4.0.1 and
> it still doesn't with your patch)
The option on the Versions dialog is creating new version on closing. And its
help
section says:
> Always save version when closing
> If you have made changes to your document, OpenOffice automatically saves a new
> version when you close the document.
> If you save the document manually, do not change the document after saving,
> and then close, no new version will be created.
It seems the behavior after the patch seems match with the description.
But I see what you want to see. It would be an enhancement.
--
You are receiving this mail because:
You are on the CC list for the issue.
You are the assignee for the issue.
You are watching all issue changes.
[Issue 123812] File - Versions - Always save a version on closing is
not working
Posted by bu...@apache.org.
https://issues.apache.org/ooo/show_bug.cgi?id=123812
Oliver-Rainer Wittmann <or...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|CONFIRMED |ACCEPTED
Assignee|hanya.runo@gmail.com |orw@apache.org
--- Comment #15 from Oliver-Rainer Wittmann <or...@apache.org> ---
As Jürgen grants the release blocker status.
As he wants to prepare new snapshots today I am taking the liberty to integrate
the patch into trunk and branch AOO410
--
You are receiving this mail because:
You are on the CC list for the issue.
You are watching all issue changes.