You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by GitBox <gi...@apache.org> on 2020/02/13 10:27:46 UTC
[GitHub] [carbondata] jackylk opened a new pull request #3619: [HOTFIX]
Remove unused fields in TableInfo
jackylk opened a new pull request #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619
### Why is this PR needed?
In TableInfo, dataMapSchemaList and parentRelationIdentifiers are always empty. If user create index or mv, neigher of their schema is stored in TableInfo, but only stored in systemfolder.
### What changes were proposed in this PR?
This PR removes dataMapSchemaList and parentRelationIdentifiers in TableInfo class
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- No
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3619: [HOTFIX]
Remove unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#issuecomment-585712697
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1975/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3619: [HOTFIX]
Remove unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#issuecomment-585666457
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/272/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on issue #3619: [HOTFIX] Remove
unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
jackylk commented on issue #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#issuecomment-586140082
> validateAllAggregateTablePresent
removed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3619: [HOTFIX] Remove
unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on issue #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#issuecomment-586126436
please help to remove parentRelationIdentifiers from TableInfoTest.java , validateAllAggregateTablePresent and registerAggregates from RefreshCarbonTableCommand class also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] jackylk commented on a change in pull request #3619:
[HOTFIX] Remove unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
jackylk commented on a change in pull request #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#discussion_r379289159
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
##########
@@ -110,28 +97,6 @@ case class CarbonDropTableCommand(
CarbonEnv.getInstance(sparkSession).carbonMetaStore.dropTable(identifier)(sparkSession)
- if (carbonTable.hasDataMapSchema) {
- // drop all child tables
- val childSchemas = carbonTable.getTableInfo.getDataMapSchemaList
-
- childDropCommands = childSchemas.asScala
- .filter(_.getRelationIdentifier != null)
- .map { childSchema =>
- val childTable =
- CarbonEnv.getCarbonTable(
- TableIdentifier(childSchema.getRelationIdentifier.getTableName,
- Some(childSchema.getRelationIdentifier.getDatabaseName)))(sparkSession)
- val dropCommand = CarbonDropTableCommand(
- ifExistsSet = true,
- Some(childSchema.getRelationIdentifier.getDatabaseName),
- childSchema.getRelationIdentifier.getTableName,
- dropChildTable = true
- )
- dropCommand.carbonTable = childTable
- dropCommand
- }
- childDropCommands.foreach(_.processMetadata(sparkSession))
- }
val indexDatamapSchemas =
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on issue #3619: [HOTFIX] Remove
unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on issue #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#issuecomment-586199051
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3619: [HOTFIX]
Remove unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#issuecomment-586179412
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1987/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] asfgit closed pull request #3619: [HOTFIX] Remove
unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3619: [HOTFIX]
Remove unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#issuecomment-585768857
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/1979/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3619: [HOTFIX]
Remove unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#issuecomment-585745007
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/276/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] CarbonDataQA1 commented on issue #3619: [HOTFIX]
Remove unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
CarbonDataQA1 commented on issue #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#issuecomment-586147787
Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/284/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [carbondata] akashrn5 commented on a change in pull request #3619:
[HOTFIX] Remove unused fields in TableInfo
Posted by GitBox <gi...@apache.org>.
akashrn5 commented on a change in pull request #3619: [HOTFIX] Remove unused fields in TableInfo
URL: https://github.com/apache/carbondata/pull/3619#discussion_r379276591
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/table/CarbonDropTableCommand.scala
##########
@@ -110,28 +97,6 @@ case class CarbonDropTableCommand(
CarbonEnv.getInstance(sparkSession).carbonMetaStore.dropTable(identifier)(sparkSession)
- if (carbonTable.hasDataMapSchema) {
- // drop all child tables
- val childSchemas = carbonTable.getTableInfo.getDataMapSchemaList
-
- childDropCommands = childSchemas.asScala
- .filter(_.getRelationIdentifier != null)
- .map { childSchema =>
- val childTable =
- CarbonEnv.getCarbonTable(
- TableIdentifier(childSchema.getRelationIdentifier.getTableName,
- Some(childSchema.getRelationIdentifier.getDatabaseName)))(sparkSession)
- val dropCommand = CarbonDropTableCommand(
- ifExistsSet = true,
- Some(childSchema.getRelationIdentifier.getDatabaseName),
- childSchema.getRelationIdentifier.getTableName,
- dropChildTable = true
- )
- dropCommand.carbonTable = childTable
- dropCommand
- }
- childDropCommands.foreach(_.processMetadata(sparkSession))
- }
val indexDatamapSchemas =
Review comment:
can you please rename this to just `datamapSchemas` because it will have MV schemas also, so indexDataMapaSchemas will give wrong meaning
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services