You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/05/19 19:20:41 UTC
[GitHub] [pinot] somandal opened a new pull request, #8738: Improve the Explain Plan accuracy
somandal opened a new pull request, #8738:
URL: https://github.com/apache/pinot/pull/8738
A vast majority of the code changes are in the tests.
The existing behavior for EXPLAIN PLAN has the following limitations:
- The plan query is sent to only one random server with a random segment. This can have the following issues:
- The segment may get pruned on the server side
- The segment may produce an Empty filter during the operator tree creation
- The segment may produce a Match All filter during the operator tree creation
- AND and OR operators may result in one or both predicate subtrees getting degenerated into an Empty or Match All filter. Due to this the AND or OR subtree may be converted into a leaf level predicate. This leads to confusion in the user's mind regarding the output of the explain plan.
- The overall approach is not a good representation of the distributed query planning for each segment
This PR address the above limitations by the following changes:
- Send the plan query to all segments on all servers (the ones chosen by the Broker after broker side pruning)
- Each server returns a set of deduplicated plans along with the count of number of segments matching each plan
- Each server returns the following data as part of the metadata:
- Number of segments pruned by the server side
- Number of segments with an empty filter tree
- Number of segments with a match all filter tree
- On the Broker side the set of plans returned by each server is again deduplicated and the number of segments matching each plan is updated for each unique plan
- Each broker returns the number of segments pruned by the broker side as part of the BrokerResponse
- Adds a verbose explain plan option which returns all of the deduplicated plans.
- If verbose is disabled (default option) then a single explain plan out of the deduplicated plan is returned with the deepest plan tree. This is a better approximation than the current explain plan functionality due to deduplication across servers and segments.
Example query:
```
EXPLAIN PLAN FOR SELECT invertedIndexCol1, noIndexCol1 FROM testTable WHERE startsWith (textIndexCol1, 'daff') AND noIndexCol4
```
Here's an example of the Explain Plan output with verbose mode enabled:
```
BROKER_REDUCE
COMBINE_SELECT
PLAN_START(numSegmentsForThisPlan:3)
SELECT(selectList:invertedIndexCol1, noIndexCol1)
TRANSFORM_PASSTHROUGH(invertedIndexCol1, noIndexCol1)
PROJECT(invertedIndexCol1, noIndexCol1)
DOC_ID_SET
FILTER_AND
FILTER_FULL_SCAN(operator:EQ,predicate:noIndexCol4 = 'true')"
FILTER_EXPRESSION(operator:EQ,predicate:startswith(textIndexCol1,'daff') = 'true')
PLAN_START(numSegmentsForThisPlan:1)
SELECT(selectList:invertedIndexCol1, noIndexCol1)
TRANSFORM_PASSTHROUGH(invertedIndexCol1, noIndexCol1)
PROJECT(invertedIndexCol1, noIndexCol1)
DOC_ID_SET
FILTER_EXPRESSION(operator:EQ,predicate:startswith(textIndexCol1,'daff') = 'true')
```
With verbose mode disabled, only the first plan will be selected as it has the deepest tree:
```
BROKER_REDUCE
COMBINE_SELECT
PLAN_START(numSegmentsForThisPlan:3)
SELECT(selectList:invertedIndexCol1, noIndexCol1)
TRANSFORM_PASSTHROUGH(invertedIndexCol1, noIndexCol1)
PROJECT(invertedIndexCol1, noIndexCol1)
DOC_ID_SET
FILTER_AND
FILTER_FULL_SCAN(operator:EQ,predicate:noIndexCol4 = 'true')"
FILTER_EXPRESSION(operator:EQ,predicate:startswith(textIndexCol1,'daff') = 'true')
```
cc @siddharthteotia
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1133646097
@somandal we can update the Pinot user docs explaining the new behavior and how to use verbose mode. I can help you do that offline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] somandal commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
somandal commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1133632752
> Rather than prefix the names for the different components, why not add another column with the component?
Yup, that's a great idea. I'll pick this up as part of my other Explain plan improvements. Thanks for the suggestion!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] amrishlal commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
amrishlal commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1132307660
Since the EXPLAIN PLAN output now gives a much broader picture, I am wondering if it makes sense to delineate the steps between server, broker, and segment a bit more, i.e. replacing the `COMBINE_XXX` nodes with `SERVER_COMBINE_XXX` nodes and replacing `PLAN_START` with `SEGMENT_PLAN` (or similar)? That way it would be much easier to tell what happened on broker or server or at segment level?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on code in PR #8738:
URL: https://github.com/apache/pinot/pull/8738#discussion_r877549589
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -446,7 +445,7 @@ private BrokerResponseNative handleRequest(long requestId, String query, JsonNod
}
if (offlineBrokerRequest == null && realtimeBrokerRequest == null) {
- if (pinotQuery.isExplain()) {
+ if (serverPinotQuery.isExplain()) {
Review Comment:
We should check the broker query instead of the server query here. Server query might be the subquery of the broker query, and it might not make sense to have EXPLAIN in the subquery
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a diff in pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on code in PR #8738:
URL: https://github.com/apache/pinot/pull/8738#discussion_r877550025
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java:
##########
@@ -548,22 +550,26 @@ private BrokerResponseNative handleRequest(long requestId, String query, JsonNod
// Execute the query
ServerStats serverStats = new ServerStats();
+ // TODO: Handle broker specific operations for explain plan queries such as:
+ // - Alias handling
+ // - Compile time function invocation
+ // - Literal only queries
+ // - Any rewrites
if (serverPinotQuery.isExplain()) {
Review Comment:
Same here, we might want to check broker query for EXPLAIN
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1132199605
@Jackie-Jiang / @richardstartin - please help take a look at the improvements here when you get a chance. I have offline worked with @somandal before putting out the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] somandal commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
somandal commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1132396115
> Since the EXPLAIN PLAN output now gives a much broader picture, I am wondering if it makes sense to delineate the steps between server, broker, and segment a bit more, i.e. replacing the `COMBINE_XXX` nodes with `SERVER_COMBINE_XXX` nodes and replacing `PLAN_START` with `SEGMENT_PLAN` (or similar)? That way it would be much easier to tell what happened on broker or server or at segment level?
@amrishlal this is a good idea, thanks for the suggestion! Discussed with @siddharthteotia and we decided to pick this up as a future enhancement (we plan to add additional explain nodes and other improvements). I'll create a ticket and a TODO for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
siddharthteotia commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1132350367
The issue https://github.com/apache/pinot/issues/8607 should be fixed by this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1132193271
# [Codecov](https://codecov.io/gh/apache/pinot/pull/8738?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#8738](https://codecov.io/gh/apache/pinot/pull/8738?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ae7354d) into [master](https://codecov.io/gh/apache/pinot/commit/96a02910f358508d9e79e0884e3d7cf4923a2405?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (96a0291) will **decrease** coverage by `6.74%`.
> The diff coverage is `84.52%`.
```diff
@@ Coverage Diff @@
## master #8738 +/- ##
============================================
- Coverage 69.65% 62.90% -6.75%
+ Complexity 4612 4598 -14
============================================
Files 1730 1686 -44
Lines 90314 88618 -1696
Branches 13421 13258 -163
============================================
- Hits 62904 55748 -7156
- Misses 23042 28853 +5811
+ Partials 4368 4017 -351
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `66.28% <85.47%> (+0.11%)` | :arrow_up: |
| unittests2 | `14.20% <4.33%> (-0.07%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/8738?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `31.16% <0.00%> (-40.35%)` | :arrow_down: |
| [...inot/core/operator/filter/EmptyFilterOperator.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvRW1wdHlGaWx0ZXJPcGVyYXRvci5qYXZh) | `87.50% <ø> (+12.50%)` | :arrow_up: |
| [...t/core/operator/filter/MatchAllFilterOperator.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9vcGVyYXRvci9maWx0ZXIvTWF0Y2hBbGxGaWx0ZXJPcGVyYXRvci5qYXZh) | `100.00% <ø> (ø)` | |
| [...va/org/apache/pinot/core/routing/RoutingTable.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9yb3V0aW5nL1JvdXRpbmdUYWJsZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...va/org/apache/pinot/spi/utils/CommonConstants.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=) | `21.31% <ø> (ø)` | |
| [...g/apache/pinot/core/common/ExplainPlanRowData.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRXhwbGFpblBsYW5Sb3dEYXRhLmphdmE=) | `62.50% <62.50%> (ø)` | |
| [.../org/apache/pinot/core/common/ExplainPlanRows.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9jb21tb24vRXhwbGFpblBsYW5Sb3dzLmphdmE=) | `82.85% <82.85%> (ø)` | |
| [...core/query/executor/ServerQueryExecutorV1Impl.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9leGVjdXRvci9TZXJ2ZXJRdWVyeUV4ZWN1dG9yVjFJbXBsLmphdmE=) | `69.62% <85.10%> (-12.57%)` | :arrow_down: |
| [...core/query/reduce/ExplainPlanDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvRXhwbGFpblBsYW5EYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `83.44% <86.95%> (+8.44%)` | :arrow_up: |
| [...che/pinot/broker/routing/BrokerRoutingManager.java](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy9Ccm9rZXJSb3V0aW5nTWFuYWdlci5qYXZh) | `59.03% <87.50%> (-26.35%)` | :arrow_down: |
| ... and [412 more](https://codecov.io/gh/apache/pinot/pull/8738/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/8738?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/8738?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [96a0291...ae7354d](https://codecov.io/gh/apache/pinot/pull/8738?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] siddharthteotia merged pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
siddharthteotia merged PR #8738:
URL: https://github.com/apache/pinot/pull/8738
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
richardstartin commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1133547956
Can you document how to toggle verbose mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] somandal commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
somandal commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1133632855
> Can you document how to toggle verbose mode?
I've updated the comment to show the query option for verbose vs. non-verbose. Is there somewhere else this needs to be documented?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] richardstartin commented on pull request #8738: Improve the Explain Plan accuracy
Posted by GitBox <gi...@apache.org>.
richardstartin commented on PR #8738:
URL: https://github.com/apache/pinot/pull/8738#issuecomment-1133547863
Rather than prefix the names for the different components, why not add another column with the component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org