You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by witgo <gi...@git.apache.org> on 2016/08/15 14:16:51 UTC
[GitHub] spark pull request #14647: [WIP][Test only][SPARK-6235]Address various 2G li...
GitHub user witgo opened a pull request:
https://github.com/apache/spark/pull/14647
[WIP][Test only][SPARK-6235]Address various 2G limits
## What changes were proposed in this pull request?
The main changes.
1. Replace DiskStore method `def getBytes (blockId: BlockId): ChunkedByteBuffer` to `def getBlockData(blockId: BlockId): ManagedBuffer` .
2. ManagedBuffer's nioByteBuffer method return ChunkedByteBuffer.
3. Add class `ChunkFetchInputStream`, used for flow control
4. Move class `ChunkedByteBuffer`, `ChunkedByteBufferInputStream` and `ChunkedByteBufferOutputStream` to `common/network-common/src/main/java/org/apache/spark/network/buffer/`
5. Replace `ByteBuffer` with `ChunkedByteBuffer`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/witgo/spark SPARK-6235_demo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14647.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14647
----
commit dc9ffd6086ab6cffc90171676b9186f23df185f8
Author: GuoQiang Li <wi...@qq.com>
Date: 2016-08-15T14:03:18Z
Address various 2G limits
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][DEMO][SPARK-6235]Address various 2G lim...
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/14647
@hvanhovell
I will submit some small PRs and provide a more high level description of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][SPARK-6235]Address various 2G limits
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14647
**[Test build #63783 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63783/consoleFull)** for PR 14647 at commit [`dc9ffd6`](https://github.com/apache/spark/commit/dc9ffd6086ab6cffc90171676b9186f23df185f8).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][DEMO][SPARK-6235]Address various 2G lim...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14647
**[Test build #63784 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63784/consoleFull)** for PR 14647 at commit [`a211c1a`](https://github.com/apache/spark/commit/a211c1a85d64bd129dfba416f4d4817b7999ae95).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][DEMO][SPARK-6235]Address various 2G lim...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14647
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63784/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][DEMO][SPARK-6235]Address various 2G lim...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14647
**[Test build #63784 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63784/consoleFull)** for PR 14647 at commit [`a211c1a`](https://github.com/apache/spark/commit/a211c1a85d64bd129dfba416f4d4817b7999ae95).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][SPARK-6235]Address various 2G limits
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14647
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/63783/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][DEMO][SPARK-6235]Address various 2G lim...
Posted by hvanhovell <gi...@git.apache.org>.
Github user hvanhovell commented on the issue:
https://github.com/apache/spark/pull/14647
@witgo Could you provide a more high level description of this PR? I am curious to see which problem you are trying to solve? Also see @srowen's comment on the JIRA.
The sheer size in lines of code and files modified make this a challenge to review. Is it an option to split this PR in number of smaller PRs? The other thing I am missing are tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14647: [WIP][Test only][DEMO][SPARK-6235]Address various...
Posted by witgo <gi...@git.apache.org>.
Github user witgo closed the pull request at:
https://github.com/apache/spark/pull/14647
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][SPARK-6235]Address various 2G limits
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14647
**[Test build #63783 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/63783/consoleFull)** for PR 14647 at commit [`dc9ffd6`](https://github.com/apache/spark/commit/dc9ffd6086ab6cffc90171676b9186f23df185f8).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class ChunkedByteBuffer implements Externalizable `
* `public class ChunkedByteBufferInputStream extends InputStream `
* `public class ChunkedByteBufferOutputStream extends OutputStream `
* `public class ChunkFetchInputStream extends InputStream `
* `public class ChunkFetchStreamCallback implements StreamCallback `
* ` case class LaunchTask(data: ChunkedByteBuffer) extends CoarseGrainedClusterMessage`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][SPARK-6235]Address various 2G limits
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14647
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][DEMO][SPARK-6235]Address various 2G lim...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14647
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14647: [WIP][Test only][DEMO][SPARK-6235]Address various 2G lim...
Posted by witgo <gi...@git.apache.org>.
Github user witgo commented on the issue:
https://github.com/apache/spark/pull/14647
@hvanhovell #14658 , #14662 and #14664
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org