You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2021/07/16 10:10:07 UTC

[GitHub] [incubator-inlong] LeBW opened a new pull request #554: [INLONG-750] Improve master.ini and broker.ini

LeBW opened a new pull request #554:
URL: https://github.com/apache/incubator-inlong/pull/554


   1. change default port to 8715 in master.ini
   2. add configuration instruction for defEthName in broker.ini


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] gosonzhang commented on a change in pull request #554: [INLONG-750] Improve master.ini and broker.ini

Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #554:
URL: https://github.com/apache/incubator-inlong/pull/554#discussion_r671601196



##########
File path: inlong-tubemq/conf/master.ini
##########
@@ -19,7 +19,7 @@
 ; host address of master, required; must be configured at network card, enabled
 hostName=127.0.0.1
 ; port that master listens to, optional; default is 8715
-port=8000
+port=8715

Review comment:
       Ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] codecov-commenter commented on pull request #554: [INLONG-750] Improve master.ini and broker.ini

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #554:
URL: https://github.com/apache/incubator-inlong/pull/554#issuecomment-881385016


   # [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/554?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#554](https://codecov.io/gh/apache/incubator-inlong/pull/554?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5ecc1ad) into [INLONG-739](https://codecov.io/gh/apache/incubator-inlong/commit/b40f666bf1349d8cb7edb295012a15c02ab37d13?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b40f666) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-inlong/pull/554/graphs/tree.svg?width=650&height=150&src=pr&token=1EUK92O9K2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/incubator-inlong/pull/554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             INLONG-739    #554   +/-   ##
   ============================================
     Coverage          7.69%   7.70%           
   - Complexity          563     564    +1     
   ============================================
     Files               355     355           
     Lines             31081   31081           
     Branches           4972    4972           
   ============================================
   + Hits               2393    2395    +2     
   + Misses            28197   28195    -2     
     Partials            491     491           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-inlong/pull/554?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../producer/qltystats/DefaultBrokerRcvQltyStats.java](https://codecov.io/gh/apache/incubator-inlong/pull/554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9pbmxvbmcvdHViZW1xL2NsaWVudC9wcm9kdWNlci9xbHR5c3RhdHMvRGVmYXVsdEJyb2tlclJjdlFsdHlTdGF0cy5qYXZh) | `45.31% <0.00%> (-0.40%)` | :arrow_down: |
   | [.../tubemq/corebase/policies/FlowCtrlRuleHandler.java](https://codecov.io/gh/apache/incubator-inlong/pull/554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybFJ1bGVIYW5kbGVyLmphdmE=) | `44.57% <0.00%> (+0.58%)` | :arrow_up: |
   | [.../inlong/tubemq/corebase/policies/FlowCtrlItem.java](https://codecov.io/gh/apache/incubator-inlong/pull/554/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aW5sb25nLXR1YmVtcS90dWJlbXEtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvaW5sb25nL3R1YmVtcS9jb3JlYmFzZS9wb2xpY2llcy9GbG93Q3RybEl0ZW0uamF2YQ==) | `40.00% <0.00%> (+1.11%)` | :arrow_up: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/554?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-inlong/pull/554?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b40f666...5ecc1ad](https://codecov.io/gh/apache/incubator-inlong/pull/554?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] gosonzhang commented on a change in pull request #554: [INLONG-750] Improve master.ini and broker.ini

Posted by GitBox <gi...@apache.org>.
gosonzhang commented on a change in pull request #554:
URL: https://github.com/apache/incubator-inlong/pull/554#discussion_r671599755



##########
File path: inlong-tubemq/conf/master.ini
##########
@@ -19,7 +19,7 @@
 ; host address of master, required; must be configured at network card, enabled
 hostName=127.0.0.1
 ; port that master listens to, optional; default is 8715
-port=8000
+port=8715

Review comment:
       Does the modification to 8715 have any special meaning?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] gosonzhang merged pull request #554: [INLONG-750] Improve master.ini and broker.ini

Posted by GitBox <gi...@apache.org>.
gosonzhang merged pull request #554:
URL: https://github.com/apache/incubator-inlong/pull/554


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-inlong] LeBW commented on a change in pull request #554: [INLONG-750] Improve master.ini and broker.ini

Posted by GitBox <gi...@apache.org>.
LeBW commented on a change in pull request #554:
URL: https://github.com/apache/incubator-inlong/pull/554#discussion_r671601055



##########
File path: inlong-tubemq/conf/master.ini
##########
@@ -19,7 +19,7 @@
 ; host address of master, required; must be configured at network card, enabled
 hostName=127.0.0.1
 ; port that master listens to, optional; default is 8715
-port=8000
+port=8715

Review comment:
       As shown in the comment in Line 21, the default port is 8715. Besides, the default port in `MasterConfig` is 8715, too.
   So maybe it's better to use 8715 here, so it won't confuse users.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org