You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by kant2002 <gi...@git.apache.org> on 2014/03/16 14:39:36 UTC
[GitHub] cordova-plugins pull request: CB-5767 Created keyboard notificatio...
GitHub user kant2002 opened a pull request:
https://github.com/apache/cordova-plugins/pull/7
CB-5767 Created keyboard notifications in JavaScript
Propagate keyboard didshow/didhide notifications to JavaScript
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kant2002/cordova-plugins CB-5767
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugins/pull/7.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7
----
commit ecd672d3b77582d808e27bc3881f10e2d7d11f5d
Author: Andrey Kurdyumov <ka...@gmail.com>
Date: 2014-02-24T09:52:58Z
Created statusbar version of plugin for Android
commit 91cb5e3ffd25162fc02fa7fef492c1fa1ed45114
Author: Andrey Kurdyumov <ka...@gmail.com>
Date: 2014-02-25T09:54:14Z
Updated docs to include support for Android
commit 4657108626f5f0b97a6d35d2897204445356d000
Author: Andrey Kurdyumov <ka...@gmail.com>
Date: 2014-03-14T06:14:25Z
Merge https://github.com/apache/cordova-plugins
commit 595e389193ff6a072c490adcd726e7af12c458af
Author: Andrey Kurdyumov <ka...@gmail.com>
Date: 2014-03-16T13:17:36Z
Fire JavaScript events when keyboard did show/hide on iOS
commit a35e2491645cc7d6646b955707d43801a7a8222d
Author: Andrey Kurdyumov <ka...@gmail.com>
Date: 2014-03-16T13:26:32Z
CB-5767 Added documentation for JavaScript keyboard events
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugins pull request: CB-5767 Created keyboard notificatio...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-plugins/pull/7#issuecomment-37763870
I also add WillShow/WillHide part of notifications in the subsequent commit. This will close issue fully.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugins pull request: CB-5767 Created keyboard notificatio...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugins/pull/7#issuecomment-37988423
Merged in: https://git-wip-us.apache.org/repos/asf?p=cordova-plugins.git;h=80561e4
You can close this PR now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugins pull request: CB-5767 Created keyboard notificatio...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-plugins/pull/7#issuecomment-37763951
Since GitHub integration does not pickup additional commit from existing pull request I will put link to additional commit below:
3. https://github.com/kant2002/cordova-plugins/commit/a35e2491645cc7d6646b955707d43801a7a8222d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugins pull request: CB-5767 Created keyboard notificatio...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 closed the pull request at:
https://github.com/apache/cordova-plugins/pull/7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugins pull request: CB-5767 Created keyboard notificatio...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-plugins/pull/7#issuecomment-37764257
And last one, where I fix typo.
https://github.com/kant2002/cordova-plugins/commit/7dabf95bfaa74ac8cda83559dffd2f23727191f0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugins pull request: CB-5767 Created keyboard notificatio...
Posted by kant2002 <gi...@git.apache.org>.
Github user kant2002 commented on the pull request:
https://github.com/apache/cordova-plugins/pull/7#issuecomment-37761239
Yes. I probably have to recreate my fork from scratch. Sorry for inconvenience.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugins pull request: CB-5767 Created keyboard notificatio...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugins/pull/7#issuecomment-37759865
This pull request contains more commits than expected.
I would think these two commits are expected for this PR?:
1. https://github.com/kant2002/cordova-plugins/commit/595e389193ff6a072c490adcd726e7af12c458af
2. https://github.com/kant2002/cordova-plugins/commit/a35e2491645cc7d6646b955707d43801a7a8222d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cordova-plugins pull request: CB-5767 Created keyboard notificatio...
Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:
https://github.com/apache/cordova-plugins/pull/7#issuecomment-37784018
Thanks! I'll squash all the 4 commits and merge them -- will get to this on Monday
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---