You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pluto-dev@portals.apache.org by "David DeWolf (JIRA)" <ji...@apache.org> on 2006/12/06 02:44:23 UTC
[jira] Resolved: (PLUTO-261) PortalServletRequest makes a redundant
check
[ http://issues.apache.org/jira/browse/PLUTO-261?page=all ]
David DeWolf resolved PLUTO-261.
--------------------------------
Resolution: Fixed
Resolved. I think you're right that was the original intent, so I went ahead and made that the change. It will never get called, and I documented it as such. I left it in b/c some day we could use it for actions.
> PortalServletRequest makes a redundant check
> --------------------------------------------
>
> Key: PLUTO-261
> URL: http://issues.apache.org/jira/browse/PLUTO-261
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.0-beta2
> Reporter: David Hay
> Assigned To: David DeWolf
> Fix For: 1.1.0
>
>
> On lines 95-96 of PortalServletRequest, the following code exists:
> String id = portletWindow.getId().getStringId();
> if (portletWindow.getId().getStringId().equals(id)) {
> This will always evaluate to true. What I suspect was intended here was the following:
> String id = portletWindow.getId().getStringId();
> if (url.getActionWindow().equals(id)) {
> So that the query parameters were only included in the request for the portlet processing an action.
> BTW, 1.1.0-beta2 is still listed as unreleased in JIRA
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira