You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Stas Bekman <st...@stason.org> on 2003/06/05 09:16:20 UTC

Re: cvs commit: modperl/t/docs/auth .htaccess

gozer@apache.org wrote:
> gozer       2003/06/05 00:09:20
> 
>   Modified:    .        Makefile.PL
>                t/docs/auth .htaccess
>   Log:
>   s/Apache::(OK|DECLINED)/Apache::Constants::$1/g

argh, now that I looked in eagle: ch06, it uses:

PerlAuthenHandler Apache::OK

And it has this footnote:

*Apache::OK is always available, along with B<Apache::DECLINED>, since
  they are imported from Apache::Constants by Apache.pm at server
  startup time.

Am I reading the source wrong or is it a typo in the book? Most likely the former.

>   Revision  Changes    Path
>   1.212     +1 -1      modperl/Makefile.PL
>   
>   Index: Makefile.PL
>   ===================================================================
>   RCS file: /home/cvs/modperl/Makefile.PL,v
>   retrieving revision 1.211
>   retrieving revision 1.212
>   diff -u -r1.211 -r1.212
>   --- Makefile.PL	16 May 2003 13:26:38 -0000	1.211
>   +++ Makefile.PL	5 Jun 2003 07:09:19 -0000	1.212
>   @@ -1239,7 +1239,7 @@
>        open FH, ">$dir/.htaccess";
>        print FH <<EOF;
>        $meth_test
>   -PerlFixupHandler  Apache::OK Apache::DECLINED MyClass::method
>   +PerlFixupHandler  Apache::Constants::OK Apache::Constants::DECLINED MyClass::method
>    EOF
>            close FH;
>    }
>   
>   
>   
>   1.5       +1 -1      modperl/t/docs/auth/.htaccess
>   
>   Index: .htaccess
>   ===================================================================
>   RCS file: /home/cvs/modperl/t/docs/auth/.htaccess,v
>   retrieving revision 1.4
>   retrieving revision 1.5
>   diff -u -r1.4 -r1.5
>   --- .htaccess	20 Jan 1999 23:16:35 -0000	1.4
>   +++ .htaccess	5 Jun 2003 07:09:20 -0000	1.5
>   @@ -2,7 +2,7 @@
>    AuthName mod_perl
>    AuthType Basic
>    PerlAuthenHandler Apache::AuthenTest
>   -PerlAuthzHandler Apache::OK
>   +PerlAuthzHandler Apache::Constants::OK
>    require valid-user
>    
>    #<Perl>
>   
>   
>   


-- 


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: cvs commit: modperl/t/docs/auth .htaccess

Posted by "Philippe M. Chiasson" <go...@cpan.org>.
On Fri, 2003-06-06 at 15:40, Stas Bekman wrote:
> Philippe M. Chiasson wrote:
> > On Thu, 2003-06-05 at 15:16, Stas Bekman wrote:
> > 
> >>gozer@apache.org wrote:
> >>
> >>>gozer       2003/06/05 00:09:20
> >>>
> >>>  Modified:    .        Makefile.PL
> >>>               t/docs/auth .htaccess
> >>>  Log:
> >>>  s/Apache::(OK|DECLINED)/Apache::Constants::$1/g
> >>
> >>argh, now that I looked in eagle: ch06, it uses:
> >>
> >>PerlAuthenHandler Apache::OK
> >>
> >>And it has this footnote:
> >>
> >>*Apache::OK is always available, along with B<Apache::DECLINED>, since
> >>  they are imported from Apache::Constants by Apache.pm at server
> >>  startup time.
> > 
> > 
> > Funny, I checked my Eagle also ;-)
> > 
> > 
> >>Am I reading the source wrong or is it a typo in the book? Most likely the former.
> > 
> > 
> > Well, the _really_ strange thing is that segfault I've been reporting on
> > this issue with all the 5.6.1 to 5.6.x(19034).
> > 
> > This change does make my problem dissapear, but after having read the
> > book, it's clear lots of people will have stuff like :
> > 
> > <Location /foo>
> >  SetHandler perl-script
> >  PerlHandler Apache::OK
> > </Location>
> > 
> > In their config somewhere for sure, and it will explode AFAIK.
> > 
> > Can anybody please try and reproduce this segfault? I will try and dig
> > deeper into it, but got no time quite yet.
> > 
> > perl_call_sv() is called with a valid SV that holds "Apache::OK", but
> > somehow the op that S_call_body retrieves is totally busted (see my
> > previous report on this thread)
> > 
> > Anyhow, one thing is for sure, I don't feel confident release mp1-28
> > until I get this particular issue resolved or at least pinpointed to
> > something borked on my side...
> 
> Can you try some older mod_perl version to see if this is something that was 
> added recently?

Fails with :

mod_perl-1-cvs
mod_perl-1.27
mod_perl-1.26
mod_perl-1.25
[...]

Can at least somebody but me see this problem with perl 5.6.?

> > Gozer out.
> > 
> > 
> > 
> >>>  Revision  Changes    Path
> >>>  1.212     +1 -1      modperl/Makefile.PL
> >>>  
> >>>  Index: Makefile.PL
> >>>  ===================================================================
> >>>  RCS file: /home/cvs/modperl/Makefile.PL,v
> >>>  retrieving revision 1.211
> >>>  retrieving revision 1.212
> >>>  diff -u -r1.211 -r1.212
> >>>  --- Makefile.PL	16 May 2003 13:26:38 -0000	1.211
> >>>  +++ Makefile.PL	5 Jun 2003 07:09:19 -0000	1.212
> >>>  @@ -1239,7 +1239,7 @@
> >>>       open FH, ">$dir/.htaccess";
> >>>       print FH <<EOF;
> >>>       $meth_test
> >>>  -PerlFixupHandler  Apache::OK Apache::DECLINED MyClass::method
> >>>  +PerlFixupHandler  Apache::Constants::OK Apache::Constants::DECLINED MyClass::method
> >>>   EOF
> >>>           close FH;
> >>>   }
> >>>  
> >>>  
> >>>  
> >>>  1.5       +1 -1      modperl/t/docs/auth/.htaccess
> >>>  
> >>>  Index: .htaccess
> >>>  ===================================================================
> >>>  RCS file: /home/cvs/modperl/t/docs/auth/.htaccess,v
> >>>  retrieving revision 1.4
> >>>  retrieving revision 1.5
> >>>  diff -u -r1.4 -r1.5
> >>>  --- .htaccess	20 Jan 1999 23:16:35 -0000	1.4
> >>>  +++ .htaccess	5 Jun 2003 07:09:20 -0000	1.5
> >>>  @@ -2,7 +2,7 @@
> >>>   AuthName mod_perl
> >>>   AuthType Basic
> >>>   PerlAuthenHandler Apache::AuthenTest
> >>>  -PerlAuthzHandler Apache::OK
> >>>  +PerlAuthzHandler Apache::Constants::OK
> >>>   require valid-user
> >>>   
> >>>   #<Perl>
> >>>  
> >>>  
> >>>  
> >>
-- 
-- -----------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/    F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'

Re: cvs commit: modperl/t/docs/auth .htaccess

Posted by Stas Bekman <st...@stason.org>.
Philippe M. Chiasson wrote:
> On Thu, 2003-06-05 at 15:16, Stas Bekman wrote:
> 
>>gozer@apache.org wrote:
>>
>>>gozer       2003/06/05 00:09:20
>>>
>>>  Modified:    .        Makefile.PL
>>>               t/docs/auth .htaccess
>>>  Log:
>>>  s/Apache::(OK|DECLINED)/Apache::Constants::$1/g
>>
>>argh, now that I looked in eagle: ch06, it uses:
>>
>>PerlAuthenHandler Apache::OK
>>
>>And it has this footnote:
>>
>>*Apache::OK is always available, along with B<Apache::DECLINED>, since
>>  they are imported from Apache::Constants by Apache.pm at server
>>  startup time.
> 
> 
> Funny, I checked my Eagle also ;-)
> 
> 
>>Am I reading the source wrong or is it a typo in the book? Most likely the former.
> 
> 
> Well, the _really_ strange thing is that segfault I've been reporting on
> this issue with all the 5.6.1 to 5.6.x(19034).
> 
> This change does make my problem dissapear, but after having read the
> book, it's clear lots of people will have stuff like :
> 
> <Location /foo>
>  SetHandler perl-script
>  PerlHandler Apache::OK
> </Location>
> 
> In their config somewhere for sure, and it will explode AFAIK.
> 
> Can anybody please try and reproduce this segfault? I will try and dig
> deeper into it, but got no time quite yet.
> 
> perl_call_sv() is called with a valid SV that holds "Apache::OK", but
> somehow the op that S_call_body retrieves is totally busted (see my
> previous report on this thread)
> 
> Anyhow, one thing is for sure, I don't feel confident release mp1-28
> until I get this particular issue resolved or at least pinpointed to
> something borked on my side...

Can you try some older mod_perl version to see if this is something that was 
added recently?

> Gozer out.
> 
> 
> 
>>>  Revision  Changes    Path
>>>  1.212     +1 -1      modperl/Makefile.PL
>>>  
>>>  Index: Makefile.PL
>>>  ===================================================================
>>>  RCS file: /home/cvs/modperl/Makefile.PL,v
>>>  retrieving revision 1.211
>>>  retrieving revision 1.212
>>>  diff -u -r1.211 -r1.212
>>>  --- Makefile.PL	16 May 2003 13:26:38 -0000	1.211
>>>  +++ Makefile.PL	5 Jun 2003 07:09:19 -0000	1.212
>>>  @@ -1239,7 +1239,7 @@
>>>       open FH, ">$dir/.htaccess";
>>>       print FH <<EOF;
>>>       $meth_test
>>>  -PerlFixupHandler  Apache::OK Apache::DECLINED MyClass::method
>>>  +PerlFixupHandler  Apache::Constants::OK Apache::Constants::DECLINED MyClass::method
>>>   EOF
>>>           close FH;
>>>   }
>>>  
>>>  
>>>  
>>>  1.5       +1 -1      modperl/t/docs/auth/.htaccess
>>>  
>>>  Index: .htaccess
>>>  ===================================================================
>>>  RCS file: /home/cvs/modperl/t/docs/auth/.htaccess,v
>>>  retrieving revision 1.4
>>>  retrieving revision 1.5
>>>  diff -u -r1.4 -r1.5
>>>  --- .htaccess	20 Jan 1999 23:16:35 -0000	1.4
>>>  +++ .htaccess	5 Jun 2003 07:09:20 -0000	1.5
>>>  @@ -2,7 +2,7 @@
>>>   AuthName mod_perl
>>>   AuthType Basic
>>>   PerlAuthenHandler Apache::AuthenTest
>>>  -PerlAuthzHandler Apache::OK
>>>  +PerlAuthzHandler Apache::Constants::OK
>>>   require valid-user
>>>   
>>>   #<Perl>
>>>  
>>>  
>>>  
>>


-- 


__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: cvs commit: modperl/t/docs/auth .htaccess

Posted by "Philippe M. Chiasson" <go...@cpan.org>.
On Thu, 2003-06-05 at 15:16, Stas Bekman wrote:
> gozer@apache.org wrote:
> > gozer       2003/06/05 00:09:20
> > 
> >   Modified:    .        Makefile.PL
> >                t/docs/auth .htaccess
> >   Log:
> >   s/Apache::(OK|DECLINED)/Apache::Constants::$1/g
> 
> argh, now that I looked in eagle: ch06, it uses:
> 
> PerlAuthenHandler Apache::OK
> 
> And it has this footnote:
> 
> *Apache::OK is always available, along with B<Apache::DECLINED>, since
>   they are imported from Apache::Constants by Apache.pm at server
>   startup time.

Funny, I checked my Eagle also ;-)

> Am I reading the source wrong or is it a typo in the book? Most likely the former.

Well, the _really_ strange thing is that segfault I've been reporting on
this issue with all the 5.6.1 to 5.6.x(19034).

This change does make my problem dissapear, but after having read the
book, it's clear lots of people will have stuff like :

<Location /foo>
 SetHandler perl-script
 PerlHandler Apache::OK
</Location>

In their config somewhere for sure, and it will explode AFAIK.

Can anybody please try and reproduce this segfault? I will try and dig
deeper into it, but got no time quite yet.

perl_call_sv() is called with a valid SV that holds "Apache::OK", but
somehow the op that S_call_body retrieves is totally busted (see my
previous report on this thread)

Anyhow, one thing is for sure, I don't feel confident release mp1-28
until I get this particular issue resolved or at least pinpointed to
something borked on my side...

Gozer out.


> >   Revision  Changes    Path
> >   1.212     +1 -1      modperl/Makefile.PL
> >   
> >   Index: Makefile.PL
> >   ===================================================================
> >   RCS file: /home/cvs/modperl/Makefile.PL,v
> >   retrieving revision 1.211
> >   retrieving revision 1.212
> >   diff -u -r1.211 -r1.212
> >   --- Makefile.PL	16 May 2003 13:26:38 -0000	1.211
> >   +++ Makefile.PL	5 Jun 2003 07:09:19 -0000	1.212
> >   @@ -1239,7 +1239,7 @@
> >        open FH, ">$dir/.htaccess";
> >        print FH <<EOF;
> >        $meth_test
> >   -PerlFixupHandler  Apache::OK Apache::DECLINED MyClass::method
> >   +PerlFixupHandler  Apache::Constants::OK Apache::Constants::DECLINED MyClass::method
> >    EOF
> >            close FH;
> >    }
> >   
> >   
> >   
> >   1.5       +1 -1      modperl/t/docs/auth/.htaccess
> >   
> >   Index: .htaccess
> >   ===================================================================
> >   RCS file: /home/cvs/modperl/t/docs/auth/.htaccess,v
> >   retrieving revision 1.4
> >   retrieving revision 1.5
> >   diff -u -r1.4 -r1.5
> >   --- .htaccess	20 Jan 1999 23:16:35 -0000	1.4
> >   +++ .htaccess	5 Jun 2003 07:09:20 -0000	1.5
> >   @@ -2,7 +2,7 @@
> >    AuthName mod_perl
> >    AuthType Basic
> >    PerlAuthenHandler Apache::AuthenTest
> >   -PerlAuthzHandler Apache::OK
> >   +PerlAuthzHandler Apache::Constants::OK
> >    require valid-user
> >    
> >    #<Perl>
> >   
> >   
> >   
-- 
-- -----------------------------------------------------------------------------
Philippe M. Chiasson /gozer\@(cpan|ectoplasm)\.org/ 88C3A5A5 (122FF51B/C634E37B)
http://gozer.ectoplasm.org/    F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3 A5A5
Q: It is impossible to make anything foolproof because fools are so ingenious.
perl -e'$$=\${gozer};{$_=unpack(P7,pack(L,$$));/^JAm_pH\n$/&&print||$$++&&redo}'