You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/20 08:25:59 UTC
[GitHub] [flink] dawidwys opened a new pull request #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
dawidwys opened a new pull request #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152
## What is the purpose of the change
It removes invalid check for null types as a result of an input type inference. Moreover it always fail for inferring output type based on surrounding info.
## Verifying this change
The behaviour in chained calls will be tested as part of FLINK-16033
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#issuecomment-588757980
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 41abc8492f8aec24518b9ff7cad8272ee2b35523 (Thu Feb 20 08:28:55 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#issuecomment-588815285
<!--
Meta data
Hash:41abc8492f8aec24518b9ff7cad8272ee2b35523 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:41abc8492f8aec24518b9ff7cad8272ee2b35523
-->
## CI report:
* 41abc8492f8aec24518b9ff7cad8272ee2b35523 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on a change in pull request #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#discussion_r381887206
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/TypeInferenceUtil.java
##########
@@ -99,6 +99,20 @@ public static AdaptedCallContext adaptArguments(
TypeInference typeInference,
CallContext callContext,
@Nullable DataType outputType) {
+ return adaptArguments(typeInference, callContext, outputType, true);
+ }
+
+ /**
+ * Adapts the call's argument if necessary.
+ *
+ * <p>This includes casts that need to be inserted, reordering of arguments (*), or insertion of default
+ * values (*) where (*) is future work.
+ */
+ public static AdaptedCallContext adaptArguments(
Review comment:
nit: I think we can even make this private. I wouldn't copy the JavaDoc then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] twalthr commented on a change in pull request #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
twalthr commented on a change in pull request #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#discussion_r381889112
##########
File path: flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/TypeInferenceUtil.java
##########
@@ -99,6 +99,20 @@ public static AdaptedCallContext adaptArguments(
TypeInference typeInference,
CallContext callContext,
@Nullable DataType outputType) {
+ return adaptArguments(typeInference, callContext, outputType, true);
+ }
+
+ /**
+ * Adapts the call's argument if necessary.
+ *
+ * <p>This includes casts that need to be inserted, reordering of arguments (*), or insertion of default
+ * values (*) where (*) is future work.
+ */
+ public static AdaptedCallContext adaptArguments(
+ TypeInference typeInference,
+ CallContext callContext,
+ @Nullable DataType outputType,
+ boolean checkNoUnknownInputTypes) {
Review comment:
nit: `allowUnknownInputTypes` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#issuecomment-588815285
<!--
Meta data
Hash:41abc8492f8aec24518b9ff7cad8272ee2b35523 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/149778865 TriggerType:PUSH TriggerID:41abc8492f8aec24518b9ff7cad8272ee2b35523
Hash:49654f6f62ab81b913b70771ddddac7e2cf4c1f5 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/149789822 TriggerType:PUSH TriggerID:49654f6f62ab81b913b70771ddddac7e2cf4c1f5
Hash:19a39aed2dfccdf83fd6494ef95fa066df25033a Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5358 TriggerType:PUSH TriggerID:19a39aed2dfccdf83fd6494ef95fa066df25033a
Hash:19a39aed2dfccdf83fd6494ef95fa066df25033a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149795708 TriggerType:PUSH TriggerID:19a39aed2dfccdf83fd6494ef95fa066df25033a
-->
## CI report:
* 41abc8492f8aec24518b9ff7cad8272ee2b35523 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/149778865)
* 49654f6f62ab81b913b70771ddddac7e2cf4c1f5 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/149789822)
* 19a39aed2dfccdf83fd6494ef95fa066df25033a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149795708) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5358)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#issuecomment-588815285
<!--
Meta data
Hash:41abc8492f8aec24518b9ff7cad8272ee2b35523 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/149778865 TriggerType:PUSH TriggerID:41abc8492f8aec24518b9ff7cad8272ee2b35523
Hash:49654f6f62ab81b913b70771ddddac7e2cf4c1f5 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149789822 TriggerType:PUSH TriggerID:49654f6f62ab81b913b70771ddddac7e2cf4c1f5
Hash:19a39aed2dfccdf83fd6494ef95fa066df25033a Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:19a39aed2dfccdf83fd6494ef95fa066df25033a
-->
## CI report:
* 41abc8492f8aec24518b9ff7cad8272ee2b35523 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/149778865)
* 49654f6f62ab81b913b70771ddddac7e2cf4c1f5 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149789822)
* 19a39aed2dfccdf83fd6494ef95fa066df25033a UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#issuecomment-588815285
<!--
Meta data
Hash:41abc8492f8aec24518b9ff7cad8272ee2b35523 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149778865 TriggerType:PUSH TriggerID:41abc8492f8aec24518b9ff7cad8272ee2b35523
Hash:49654f6f62ab81b913b70771ddddac7e2cf4c1f5 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:49654f6f62ab81b913b70771ddddac7e2cf4c1f5
-->
## CI report:
* 41abc8492f8aec24518b9ff7cad8272ee2b35523 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149778865)
* 49654f6f62ab81b913b70771ddddac7e2cf4c1f5 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] dawidwys merged pull request #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
dawidwys merged pull request #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#issuecomment-588815285
<!--
Meta data
Hash:41abc8492f8aec24518b9ff7cad8272ee2b35523 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/149778865 TriggerType:PUSH TriggerID:41abc8492f8aec24518b9ff7cad8272ee2b35523
Hash:49654f6f62ab81b913b70771ddddac7e2cf4c1f5 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/149789822 TriggerType:PUSH TriggerID:49654f6f62ab81b913b70771ddddac7e2cf4c1f5
Hash:19a39aed2dfccdf83fd6494ef95fa066df25033a Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5358 TriggerType:PUSH TriggerID:19a39aed2dfccdf83fd6494ef95fa066df25033a
Hash:19a39aed2dfccdf83fd6494ef95fa066df25033a Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149795708 TriggerType:PUSH TriggerID:19a39aed2dfccdf83fd6494ef95fa066df25033a
-->
## CI report:
* 41abc8492f8aec24518b9ff7cad8272ee2b35523 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/149778865)
* 49654f6f62ab81b913b70771ddddac7e2cf4c1f5 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/149789822)
* 19a39aed2dfccdf83fd6494ef95fa066df25033a Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149795708) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5358)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#issuecomment-588815285
<!--
Meta data
Hash:41abc8492f8aec24518b9ff7cad8272ee2b35523 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/149778865 TriggerType:PUSH TriggerID:41abc8492f8aec24518b9ff7cad8272ee2b35523
Hash:49654f6f62ab81b913b70771ddddac7e2cf4c1f5 Status:CANCELED URL:https://travis-ci.com/flink-ci/flink/builds/149789822 TriggerType:PUSH TriggerID:49654f6f62ab81b913b70771ddddac7e2cf4c1f5
Hash:19a39aed2dfccdf83fd6494ef95fa066df25033a Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5358 TriggerType:PUSH TriggerID:19a39aed2dfccdf83fd6494ef95fa066df25033a
Hash:19a39aed2dfccdf83fd6494ef95fa066df25033a Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/149795708 TriggerType:PUSH TriggerID:19a39aed2dfccdf83fd6494ef95fa066df25033a
-->
## CI report:
* 41abc8492f8aec24518b9ff7cad8272ee2b35523 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/149778865)
* 49654f6f62ab81b913b70771ddddac7e2cf4c1f5 Travis: [CANCELED](https://travis-ci.com/flink-ci/flink/builds/149789822)
* 19a39aed2dfccdf83fd6494ef95fa066df25033a Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/149795708) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5358)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11152:
[FLINK-16182][table-api] Remove check against null types as a result of an
input type inference
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11152: [FLINK-16182][table-api] Remove check against null types as a result of an input type inference
URL: https://github.com/apache/flink/pull/11152#issuecomment-588815285
<!--
Meta data
Hash:41abc8492f8aec24518b9ff7cad8272ee2b35523 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/149778865 TriggerType:PUSH TriggerID:41abc8492f8aec24518b9ff7cad8272ee2b35523
-->
## CI report:
* 41abc8492f8aec24518b9ff7cad8272ee2b35523 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/149778865)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services