[jira] [Commented] (KAFKA-9329) KafkaController::replicasAreValid should return error

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-9329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018369#comment-17018369 ] 

ASF GitHub Bot commented on KAFKA-9329:
---------------------------------------

hachikuji commented on pull request #7865: KAFKA-9329. KafkaController::replicasAreValid should return error
URL: https://github.com/apache/kafka/pull/7865
 
 
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> KafkaController::replicasAreValid should return error
> -----------------------------------------------------
>
>                 Key: KAFKA-9329
>                 URL: https://issues.apache.org/jira/browse/KAFKA-9329
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Vikas Singh
>            Assignee: Vikas Singh
>            Priority: Major
>
> The method currently returns a boolean indicating if replicas are valid or not. But the failure condition loses any context on why replicas are not valid. We should return the error condition along with success/failure.
> Maybe change method name to something like `validateReplicas` too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)