You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/01/18 09:58:00 UTC
[GitHub] [skywalking-query-protocol] arugal opened a new pull request #30:
Support query browser error log
arugal opened a new pull request #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30
ref: [skywalking#4166](https://github.com/apache/skywalking/issues/4166)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] wu-sheng commented on issue #30:
Support query browser error log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-575906990
Let's hold this PR until @Fine0830 is back from the vacation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] wu-sheng commented on issue #30:
Support query browser error log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-581113626
Please follow https://github.com/apache/skywalking/pull/4228 comments and update this PR naming to keep consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] Fine0830 commented on a change in pull
request #30: Support query browser error log
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#discussion_r373826583
##########
File path: browser-error-log.graphqls
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# The list of browser error log
+type BrowserErrorLogBrief {
+ errorLogs: [BasicBrowserErrorLog!]!
+ total: Int!
+}
+
+# Browser error log basic info
+type BasicBrowserErrorLog {
+ uniqueId: String!
+ pagePath: String!
+ time: Long!
+}
+
+# Represent the conditions used for query BrowserErrorLogBrief
+input BrowserErrorLogQueryCondition {
+ # The value of 0 means all services.
+ serviceId: ID
+ serviceVersionId: ID
+ pagePathId: ID
+ pagePath: String
+ # The time range of browser perf data time
+ queryDuration: Duration
+ paging: Pagination!
Review comment:
OK
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] wu-sheng commented on issue #30:
Support query browser error log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-581422883
@Fine0830 Do we provide log query from UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] Fine0830 commented on issue #30:
Support query browser error log
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on issue #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-581715189
> @Fine0830 Do we provide log query from UI?
Hum... we need to provide error logs query. I have no ideas for other logs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull
request #30: Support query browser error log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#discussion_r371220338
##########
File path: browser-error-log.graphqls
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# The list of browser error log
+type BrowserErrorLogBrief {
+ errorLogs: [BasicBrowserErrorLog!]!
+ total: Int!
+}
+
+# Browser error log basic info
+type BasicBrowserErrorLog {
+ uniqueId: String!
+ pagePath: String!
+ time: Long!
+}
+
+# Represent the conditions used for query BrowserErrorLogBrief
+input BrowserErrorLogQueryCondition {
+ # The value of 0 means all services.
+ serviceId: ID
+ serviceVersionId: ID
+ pagePathId: ID
+ pagePath: String
+ # The time range of browser perf data time
+ queryDuration: Duration
+ paging: Pagination!
Review comment:
This is UI query protocol, not client-js upstream protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] arugal commented on issue #30: Support
query browser error log
Posted by GitBox <gi...@apache.org>.
arugal commented on issue #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-576581932
> All of `time` fields are able to be generated on server when server get logs from browser? @arugal
When `time == 0`, `time` is set to the current time on the server side.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] Fine0830 commented on a change in pull
request #30: Support query browser error log
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#discussion_r368980576
##########
File path: browser-error-log.graphqls
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# The list of browser error log
+type BrowserErrorLogBrief {
+ errorLogs: [BasicBrowserErrorLog!]!
+ total: Int!
+}
+
+# Browser error log basic info
+type BasicBrowserErrorLog {
+ uniqueId: String!
+ pagePath: String!
+ time: Long!
+}
+
+# Represent the conditions used for query BrowserErrorLogBrief
+input BrowserErrorLogQueryCondition {
+ # The value of 0 means all services.
+ serviceId: ID
+ serviceVersionId: ID
+ pagePathId: ID
+ pagePath: String
+ # The time range of browser perf data time
+ queryDuration: Duration
+ paging: Pagination!
Review comment:
I don't understand `queryDuration ` and `paging ` fields. Every log time is the current time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] wu-sheng commented on a change in pull
request #30: Support query browser error log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#discussion_r371220087
##########
File path: browser-error-log.graphqls
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# The list of browser error log
+type BrowserErrorLogBrief {
+ errorLogs: [BasicBrowserErrorLog!]!
+ total: Int!
+}
+
+# Browser error log basic info
+type BasicBrowserErrorLog {
+ uniqueId: String!
+ pagePath: String!
+ time: Long!
+}
+
+# Represent the conditions used for query BrowserErrorLogBrief
+input BrowserErrorLogQueryCondition {
+ # The value of 0 means all services.
+ serviceId: ID
+ serviceVersionId: ID
+ pagePathId: ID
+ pagePath: String
Review comment:
I think we could keep pathId only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] wu-sheng commented on issue #30:
Support query browser error log
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-578730842
> If time is able to be generated with the current time on server side, we need to remove it from there.
This is the UI/CLI query protocol.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] Fine0830 commented on issue #30:
Support query browser error log
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on issue #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-576493982
Today, I have time to review this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] Fine0830 commented on a change in pull
request #30: Support query browser error log
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#discussion_r368978602
##########
File path: browser-error-log.graphqls
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# The list of browser error log
+type BrowserErrorLogBrief {
+ errorLogs: [BasicBrowserErrorLog!]!
+ total: Int!
+}
+
+# Browser error log basic info
+type BasicBrowserErrorLog {
+ uniqueId: String!
+ pagePath: String!
+ time: Long!
+}
+
+# Represent the conditions used for query BrowserErrorLogBrief
+input BrowserErrorLogQueryCondition {
+ # The value of 0 means all services.
+ serviceId: ID
+ serviceVersionId: ID
+ pagePathId: ID
+ pagePath: String
+ # The time range of browser perf data time
+ queryDuration: Duration
+ paging: Pagination!
+}
+
+type BrowserPerfData {
+ uniqueId: String!
+ serviceId: ID!
+ serviceName: String!
+ serviceVersionId: ID!
+ serviceVersionName: String!
+ pagePathId: ID!
+ pagePath: String!
Review comment:
As above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] Fine0830 commented on a change in pull
request #30: Support query browser error log
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#discussion_r368975725
##########
File path: browser-error-log.graphqls
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# The list of browser error log
+type BrowserErrorLogBrief {
+ errorLogs: [BasicBrowserErrorLog!]!
+ total: Int!
+}
+
+# Browser error log basic info
+type BasicBrowserErrorLog {
+ uniqueId: String!
+ pagePath: String!
+ time: Long!
+}
+
+# Represent the conditions used for query BrowserErrorLogBrief
+input BrowserErrorLogQueryCondition {
+ # The value of 0 means all services.
+ serviceId: ID
+ serviceVersionId: ID
+ pagePathId: ID
+ pagePath: String
Review comment:
I think we just need one of them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] Fine0830 commented on a change in pull
request #30: Support query browser error log
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on a change in pull request #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#discussion_r368980576
##########
File path: browser-error-log.graphqls
##########
@@ -0,0 +1,81 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# The list of browser error log
+type BrowserErrorLogBrief {
+ errorLogs: [BasicBrowserErrorLog!]!
+ total: Int!
+}
+
+# Browser error log basic info
+type BasicBrowserErrorLog {
+ uniqueId: String!
+ pagePath: String!
+ time: Long!
+}
+
+# Represent the conditions used for query BrowserErrorLogBrief
+input BrowserErrorLogQueryCondition {
+ # The value of 0 means all services.
+ serviceId: ID
+ serviceVersionId: ID
+ pagePathId: ID
+ pagePath: String
+ # The time range of browser perf data time
+ queryDuration: Duration
+ paging: Pagination!
Review comment:
I don't understand `queryDuration ` and `paging ` fields. Every log time is the current time when client report logs to server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking-query-protocol] Fine0830 commented on issue #30:
Support query browser error log
Posted by GitBox <gi...@apache.org>.
Fine0830 commented on issue #30: Support query browser error log
URL: https://github.com/apache/skywalking-query-protocol/pull/30#issuecomment-576661309
> > All of `time` fields are able to be generated on server when server get logs from browser? @arugal
>
> When `time == 0`, `time` is set to the current time on the server side.
@arugal If `time` is able to be generated with the current time on server side, we need to remove it from there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services