You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "IrenaPan (via GitHub)" <gi...@apache.org> on 2025/11/11 09:27:26 UTC
[PR] [SPARK-54301][SQL][TESTS] Enhance Spark SQL test suites for easier integration with other projects [spark]
IrenaPan opened a new pull request, #52996:
URL: https://github.com/apache/spark/pull/52996
### What changes were proposed in this pull request?
This PR refactors Spark SQL test suites(`KeyGroupedPartitioningSuite` and `DisableUnnecessaryBucketedScanSuite`) to facilitate seamless integration with other projects. e.g.: Apache Gluten.
### Why are the changes needed?
Simplifying future maintenance and cross-project support.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
No production code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54301][SQL][TESTS] Enhance Spark SQL test suites for easier integration with other projects [spark]
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum commented on PR #52996:
URL: https://github.com/apache/spark/pull/52996#issuecomment-3522368913
Merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54301][SQL][TESTS] Enhance Spark SQL test suites for easier integration with other projects [spark]
Posted by "IrenaPan (via GitHub)" <gi...@apache.org>.
IrenaPan commented on code in PR #52996:
URL: https://github.com/apache/spark/pull/52996#discussion_r2513536661
##########
sql/core/src/test/scala/org/apache/spark/sql/connector/KeyGroupedPartitioningSuite.scala:
##########
@@ -299,13 +299,13 @@ class KeyGroupedPartitioningSuite extends DistributionAndOrderingSuiteBase {
Row("bbb", 20, 250.0), Row("bbb", 20, 350.0), Row("ccc", 30, 400.50)))
}
- private def collectAllShuffles(plan: SparkPlan): Seq[ShuffleExchangeExec] = {
+ protected def collectAllShuffles(plan: SparkPlan): Seq[ShuffleExchangeLike] = {
collect(plan) {
case s: ShuffleExchangeExec => s
}
}
- private def collectShuffles(plan: SparkPlan): Seq[ShuffleExchangeExec] = {
+ protected def collectShuffles(plan: SparkPlan): Seq[ShuffleExchangeLike] = {
Review Comment:
For Apache gluten, we will override it when running this suite: https://github.com/apache/incubator-gluten/blob/main/gluten-ut/spark35/src/test/scala/org/apache/spark/sql/connector/GlutenKeyGroupedPartitioningSuite.scala
override def collectAllShuffles(plan: SparkPlan): Seq[ShuffleExchangeLike] = {
collect(plan) { case s: ColumnarShuffleExchangeExec => s }
}
override def collectShuffles(plan: SparkPlan): Seq[ShuffleExchangeLike] = {
// here we skip collecting shuffle operators that are not associated with SMJ
collect(plan) { case s: SortMergeJoinExecTransformer => s }.flatMap(
smj => collect(smj) { case s: ColumnarShuffleExchangeExec => s })
}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-54301][SQL][TESTS] Enhance Spark SQL test suites for easier integration with other projects [spark]
Posted by "wangyum (via GitHub)" <gi...@apache.org>.
wangyum closed pull request #52996: [SPARK-54301][SQL][TESTS] Enhance Spark SQL test suites for easier integration with other projects
URL: https://github.com/apache/spark/pull/52996
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org