You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 01:01:35 UTC
Review Request 70092: Updated to pylint-2.3.0.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/
-----------------------------------------------------------
Review request for mesos and Armand Grillet.
Repository: mesos
Description
-------
Updated to pylint-2.3.0.
Diffs
-----
src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7
src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69
support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4
Diff: https://reviews.apache.org/r/70092/diff/1/
Testing
-------
`make check`
This currently triggers MESOS-9629 if one invokes a linter. It does not fail `make check` unless we implement MESOS-9628.
Thanks,
Benjamin Bannier
Re: Review Request 70092: Updated to pylint-2.3.0.
Posted by Benjamin Bannier <be...@mesosphere.io>.
> On March 3, 2019, 9:25 a.m., Armand Grillet wrote:
> > support/mesos-style.py
> > Lines 251 (patched)
> > <https://reviews.apache.org/r/70092/diff/1/?file=2128265#file2128265line251>
> >
> > Why is this necessary? The directory `.tox` should mainly have `.py` and `.pyc` but no C++ source files.
You are correct, not needed here ATM, removing.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/#review213364
-----------------------------------------------------------
On March 3, 2019, 11:36 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70092/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 11:36 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated to pylint-2.3.0.
>
>
> Diffs
> -----
>
> src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7
> src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69
>
>
> Diff: https://reviews.apache.org/r/70092/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
> This currently triggers MESOS-9629 if one invokes a linter. It does not fail `make check` unless we implement MESOS-9628.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70092: Updated to pylint-2.3.0.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/#review213364
-----------------------------------------------------------
support/mesos-style.py
Lines 251 (patched)
<https://reviews.apache.org/r/70092/#comment299302>
Why is this necessary? The directory `.tox` should mainly have `.py` and `.pyc` but no C++ source files.
- Armand Grillet
On March 3, 2019, 2:01 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70092/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 2:01 a.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated to pylint-2.3.0.
>
>
> Diffs
> -----
>
> src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7
> src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69
> support/mesos-style.py 11d5f96d4ca534a7d51ed93d2d6b0c528d31fad4
>
>
> Diff: https://reviews.apache.org/r/70092/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
> This currently triggers MESOS-9629 if one invokes a linter. It does not fail `make check` unless we implement MESOS-9628.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70092: Updated to pylint-2.3.1.
Posted by Armand Grillet <ag...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/#review213374
-----------------------------------------------------------
Ship it!
Ship It!
- Armand Grillet
On March 3, 2019, 12:39 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70092/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 12:39 p.m.)
>
>
> Review request for mesos and Armand Grillet.
>
>
> Bugs: MESOS-9629
> https://issues.apache.org/jira/browse/MESOS-9629
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated to pylint-2.3.1.
>
>
> Diffs
> -----
>
> src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7
> src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69
> support/pip-requirements.txt c8839fd2471826e8ca6bc023b3a0f4a38af9f899
>
>
> Diff: https://reviews.apache.org/r/70092/diff/3/
>
>
> Testing
> -------
>
> * `make check`
> * `./support/mesos-style.py`
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70092: Updated to pylint-2.3.1.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/
-----------------------------------------------------------
(Updated March 3, 2019, 12:39 p.m.)
Review request for mesos and Armand Grillet.
Changes
-------
Upgrade to 2.3.1 instead
Summary (updated)
-----------------
Updated to pylint-2.3.1.
Bugs: MESOS-9629
https://issues.apache.org/jira/browse/MESOS-9629
Repository: mesos
Description (updated)
-------
Updated to pylint-2.3.1.
Diffs (updated)
-----
src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7
src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69
support/pip-requirements.txt c8839fd2471826e8ca6bc023b3a0f4a38af9f899
Diff: https://reviews.apache.org/r/70092/diff/3/
Changes: https://reviews.apache.org/r/70092/diff/2-3/
Testing (updated)
-------
* `make check`
* `./support/mesos-style.py`
Thanks,
Benjamin Bannier
Re: Review Request 70092: Updated to pylint-2.3.0.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70092/
-----------------------------------------------------------
(Updated March 3, 2019, 11:36 a.m.)
Review request for mesos and Armand Grillet.
Changes
-------
Address issue raised by Armand
Repository: mesos
Description
-------
Updated to pylint-2.3.0.
Diffs (updated)
-----
src/python/cli_new/tox.ini 236adc7425a57d3e1fae35432527c83ccb46a4c7
src/python/lib/tox.ini 3ee77681a9b802cd5b4a7910779b8d50aac4cf69
Diff: https://reviews.apache.org/r/70092/diff/2/
Changes: https://reviews.apache.org/r/70092/diff/1-2/
Testing
-------
`make check`
This currently triggers MESOS-9629 if one invokes a linter. It does not fail `make check` unless we implement MESOS-9628.
Thanks,
Benjamin Bannier