You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by "asmcos (via GitHub)" <gi...@apache.org> on 2023/02/26 03:12:21 UTC

[GitHub] [echarts] asmcos opened a new issue, #18311: [Bug] ccandlestickLayout.ts display error.

asmcos opened a new issue, #18311:
URL: https://github.com/apache/echarts/issues/18311

   ### Version
   
   laster version
   
   ### Link to Minimal Reproduction
   
   _No response_
   
   ### Steps to Reproduce
   
   example:
   https://echarts.apache.org/examples/zh/editor.html?c=candlestick-large
   
   ### Current Behavior
   
   browser this example and wheel mouse:
   https://echarts.apache.org/examples/zh/editor.html?c=candlestick-large
   
   some candlestick display is shift.
   
   ### Expected Behavior
   
   display is middle.
   
   ### Environment
   
   ```markdown
   - OS:
   - Browser:
   - Framework:
   ```
   
   
   ### Any additional comments?
   
   candlestickLayout.ts
   subPixelOptimize cause display shift.
   
               function addBodyEnd(ends: number[][], point: number[], start: number) {
                 ....
                   point1[cDimIdx] = subPixelOptimize(
                       point1[cDimIdx] + candleWidth / 2, 1, false
                   );
                   point2[cDimIdx] = subPixelOptimize(
                       point2[cDimIdx] - candleWidth / 2, 1, true
                   );
   
   ....
               }
   
   ---> modify code as:
                   point1[cDimIdx] = subPixelOptimize(
                       point1[cDimIdx] , 1, false
                   ) +  candleWidth / 2 ;
                   point2[cDimIdx] = subPixelOptimize(
                       point2[cDimIdx] , 1, true
                   ) -  candleWidth / 2 ;
   
   This code is work.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Ovilia commented on issue #18311: [Bug] ccandlestickLayout.ts display error.

Posted by "Ovilia (via GitHub)" <gi...@apache.org>.
Ovilia commented on issue #18311:
URL: https://github.com/apache/echarts/issues/18311#issuecomment-1453033378

   Not sure how to reproduce the problem. The link doesn't seem to match your screenshot.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] RavalikaP commented on issue #18311: [Bug] ccandlestickLayout.ts display error.

Posted by "RavalikaP (via GitHub)" <gi...@apache.org>.
RavalikaP commented on issue #18311:
URL: https://github.com/apache/echarts/issues/18311#issuecomment-1681963697

   > 
   Hi, how can we give the width of the candle dynamically based on the zoom?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] asmcos commented on issue #18311: [Bug] ccandlestickLayout.ts display error.

Posted by "asmcos (via GitHub)" <gi...@apache.org>.
asmcos commented on issue #18311:
URL: https://github.com/apache/echarts/issues/18311#issuecomment-1445599299

   ![1cc4bc209dc234519d36d25e30eaf30](https://user-images.githubusercontent.com/641492/221460887-09e0bb58-5afe-4c3f-8f28-4d659b98adee.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org