You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by re...@apache.org on 2002/05/10 05:02:25 UTC
cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves ErrorReportValve.java
remm 02/05/09 20:02:25
Modified: catalina/src/share/org/apache/catalina/valves
ErrorReportValve.java
Log:
- Don't output error reports for all 1xx and 2xx status codes.
Revision Changes Path
1.10 +6 -15 jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java
Index: ErrorReportValve.java
===================================================================
RCS file: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java,v
retrieving revision 1.9
retrieving revision 1.10
diff -u -r1.9 -r1.10
--- ErrorReportValve.java 24 Jan 2002 16:47:58 -0000 1.9
+++ ErrorReportValve.java 10 May 2002 03:02:25 -0000 1.10
@@ -1,7 +1,7 @@
/*
- * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java,v 1.9 2002/01/24 16:47:58 remm Exp $
- * $Revision: 1.9 $
- * $Date: 2002/01/24 16:47:58 $
+ * $Header: /home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves/ErrorReportValve.java,v 1.10 2002/05/10 03:02:25 remm Exp $
+ * $Revision: 1.10 $
+ * $Date: 2002/05/10 03:02:25 $
*
* ====================================================================
*
@@ -105,7 +105,7 @@
* @author Craig R. McClanahan
* @author <a href="mailto:nicolaken@supereva.it">Nicola Ken Barozzi</a> Aisa
* @author <a href="mailto:stefano@apache.org">Stefano Mazzocchi</a>
- * @version $Revision: 1.9 $ $Date: 2002/01/24 16:47:58 $
+ * @version $Revision: 1.10 $ $Date: 2002/05/10 03:02:25 $
*/
public class ErrorReportValve
@@ -249,17 +249,8 @@
if (message == null)
message = "";
- // Do nothing on a 1xx status
- if (statusCode < 200)
- return;
- // Do nothing on an OK status
- if (statusCode == HttpServletResponse.SC_OK)
- return;
- // Do nothing on a NOT MODIFIED status
- if (statusCode == HttpServletResponse.SC_NOT_MODIFIED)
- return;
- // Do nothing on a NO CONTENT status
- if (statusCode == HttpServletResponse.SC_NO_CONTENT)
+ // Do nothing on a 1xx and 2xx status
+ if (statusCode < 300)
return;
// FIXME: Reset part of the request
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves ErrorReportValve.java
Posted by Remy Maucherat <re...@apache.org>.
> > - // Do nothing on a NOT MODIFIED status
> > - if (statusCode == HttpServletResponse.SC_NOT_MODIFIED)
> > - return;
> This is actually 304.
Great catch. Thanks !
Remy
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>
Re: cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/valves ErrorReportValve.java
Posted by Bill Barker <wb...@wilshire.com>.
> - // Do nothing on a NOT MODIFIED status
> - if (statusCode == HttpServletResponse.SC_NOT_MODIFIED)
> - return;
This is actually 304.
--
To unsubscribe, e-mail: <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>