You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bookkeeper.apache.org by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org> on 2012/05/07 17:30:51 UTC
[jira] [Commented] (BOOKKEEPER-72) Fix warnings issued by FindBugs
[ https://issues.apache.org/jira/browse/BOOKKEEPER-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269694#comment-13269694 ]
jiraposter@reviews.apache.org commented on BOOKKEEPER-72:
---------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5051/
-----------------------------------------------------------
Review request for bookkeeper.
Summary
-------
This patch is for the hedwig components of Bookkeeper.
This addresses bug BOOKKEEPER-72.
https://issues.apache.org/jira/browse/BOOKKEEPER-72
Diffs
-----
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/AbstractSubscriptionManager.java ba841af
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/ProxyConfiguration.java fc811e9
hedwig-server/src/main/java/org/apache/hedwig/server/regions/RegionManager.java b84d9c3
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/ReadAheadCache.java 4df1368
hedwig-server/src/main/java/org/apache/hedwig/server/proxy/HedwigProxy.java 118340a
hedwig-server/src/main/java/org/apache/hedwig/server/persistence/LocalDBPersistenceManager.java 4eff593
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/DeliveryManager.java 7ac6d43
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/FIFODeliveryManager.java 7cc950c
hedwig-server/src/main/java/org/apache/hedwig/server/handlers/NettyHandlerBean.java 71c481e
hedwig-server/src/main/java/org/apache/hedwig/server/netty/PubSubServer.java 52089f5
hedwig-server/src/main/java/org/apache/hedwig/server/netty/ServerStats.java 925e6b7
hedwig-server/src/main/java/org/apache/hedwig/admin/console/ReadTopic.java cfea7f4
hedwig-server/src/main/java/org/apache/hedwig/server/common/TerminateJVMExceptionHandler.java ae8f439
hedwig-server/src/main/java/org/apache/hedwig/server/delivery/ChannelEndPoint.java b5e9922
hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigCommands.java a17f56b
hedwig-server/src/main/java/org/apache/hedwig/admin/console/HedwigConsole.java 5da8e16
hedwig-client/src/main/java/org/apache/hedwig/util/HedwigSocketAddress.java a6cf89e
hedwig-client/src/main/java/org/apache/hedwig/util/PathUtils.java b989057
hedwig-protocol/src/main/java/org/apache/hedwig/protoextensions/PubSubResponseUtils.java 8660544
hedwig-server/pom.xml 12c8eba
hedwig-server/src/main/java/org/apache/hedwig/admin/HedwigAdmin.java b2ef3a8
hedwig-client/src/main/java/org/apache/hedwig/client/handlers/SubscribeResponseHandler.java c17ffcb
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkUtils.java 77a09d0
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkPublisher.java 54c5ce5
hedwig-client/src/main/java/org/apache/hedwig/client/benchmark/BenchmarkSubscriber.java 5ff4bc8
hedwig-server/src/main/java/org/apache/hedwig/server/subscriptions/TrueFilter.java 3804705
hedwig-server/src/main/java/org/apache/hedwig/server/topics/ZkTopicManager.java 5fbcbc4
hedwig-server/src/main/java/org/apache/hedwig/zookeeper/SafeAsyncCallback.java d1f755e
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigHubTestBase.java 6d91167
hedwig-server/src/test/java/org/apache/hedwig/server/HedwigRegionTestBase.java 2252f43
hedwig-server/src/test/java/org/apache/hedwig/server/PubSubServerStandAloneTestBase.java 5f6e363
hedwig-server/src/test/java/org/apache/hedwig/server/TestPubSubServerStartup.java 65e2bd2
hedwig-server/src/test/java/org/apache/hedwig/server/delivery/StubDeliveryManager.java fdc308d
hedwig-server/src/test/java/org/apache/hedwig/server/integration/TestHedwigHub.java eef014c
hedwig-server/src/test/java/org/apache/hedwig/server/netty/TestPubSubServer.java a11921e
Diff: https://reviews.apache.org/r/5051/diff
Testing
-------
Thanks,
Ivan
> Fix warnings issued by FindBugs
> -------------------------------
>
> Key: BOOKKEEPER-72
> URL: https://issues.apache.org/jira/browse/BOOKKEEPER-72
> Project: Bookkeeper
> Issue Type: Bug
> Reporter: Ivan Kelly
> Assignee: Ivan Kelly
> Priority: Blocker
> Fix For: 4.1.0
>
> Attachments: BOOKKEEPER-72.diff, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml, findbugsXml.xml
>
>
> Fix warnings issued by FindBugs
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira