You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dstandish (via GitHub)" <gi...@apache.org> on 2024/07/19 18:31:59 UTC

[PR] Use clearer event naming for UI task instance actions [airflow]

dstandish opened a new pull request, #40895:
URL: https://github.com/apache/airflow/pull/40895

   This makes it a little clearer to the user what actually happened.  Here is an example
   
   <img width="870" alt="image" src="https://github.com/user-attachments/assets/21f144a1-17ea-4ca9-88cc-3fc30add3605">
   
   See there it says "marked cleared" instead of just `clear`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684876951


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   -1 on `manually`. If we remove `root` and `airflow` owners and only show actual users then it should be obvious



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684879219


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   so how does it look to everyone now?
   
   i have it as 
   ```
   cleared
   marked failed
   marked success
   ```
   this seems good enough to me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684876951


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   -1 on `manually`. If we remove `root` and `airflow` owners and only show actual users then it should be obvious
   
   
   We do prefix events from the rest api as `api.`, of when its the same origin as `ui.` perhaps we do the same here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684834538


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   > same question, why are you using « marked » in all the action?
   
   because with the state there is no way to tell that it is a user action.
   
   there are machine-generated events recorded for `success` and `running`.
   
   we must put something in the event name to distinguish from those and to make clear it's a user action.
   
   it's necessariy for `marked failed` and `marked success` because someone is manually marking those states.  it's not for `cleared` because that verb implies already that it is a manual action i think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684829105


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   ok yeah marked cleared isn't even english.. ok it's a different thing than marking state... never mind!  i'll update i



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40895: Use clearer event naming for UI task instance actions
URL: https://github.com/apache/airflow/pull/40895


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684825784


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   same question, why are you using « marked » in all the action?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #40895:
URL: https://github.com/apache/airflow/pull/40895#issuecomment-2240278993

   any other concern @bbovenzi ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684852475


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="cleared")

Review Comment:
   Should we have it as manually cleared?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684817007


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   How about just "cleared"? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684827112


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   if the concern is width... there will be other events that have more verbose names than even these.....



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1688564370


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   Sure. those work for me



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "ephraimbuddy (via GitHub)" <gi...@apache.org>.
ephraimbuddy commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684854833


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   I think `manually cleared` would be appropriate here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1685090146


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="cleared")

Review Comment:
   i am ok with either.  i think @bbovenzi does not like it.  i don't have a strong opinion.  but i think `cleared` is *definitely* better than `clear` :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on code in PR #40895:
URL: https://github.com/apache/airflow/pull/40895#discussion_r1684826368


##########
airflow/www/views.py:
##########
@@ -2373,7 +2373,7 @@ def _clear_dag_tis(
 
     @expose("/clear", methods=["POST"])
     @auth.has_access_dag("PUT", DagAccessEntity.TASK_INSTANCE)
-    @action_logging
+    @action_logging(event="marked cleared")

Review Comment:
   it's ok with me. but what do you do with `success`?  `successed`? :) 
   maybe we have to do `marked` with all of them to be consistent?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Use clearer event naming for UI task instance actions [airflow]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40895:
URL: https://github.com/apache/airflow/pull/40895#issuecomment-2334958989

   This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org