[jira] [Resolved] (HBASE-24340) PerformanceEvaluation options should not mandate any specific order

["Anoop Sam John (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HBASE-24340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anoop Sam John resolved HBASE-24340.
------------------------------------
    Hadoop Flags: Reviewed
      Resolution: Fixed

> PerformanceEvaluation options should not mandate any specific order
> -------------------------------------------------------------------
>
>                 Key: HBASE-24340
>                 URL: https://issues.apache.org/jira/browse/HBASE-24340
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.1.0
>            Reporter: Anoop Sam John
>            Assignee: Sambit Mohapatra
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.4.0
>
>
> During parsing of options, there are some validations.  One such is checking whether autoFlush = false AND multiPut > 0.  This validation code mandates an order that autoFlush=true should be specified before adding multiPut = x in PE command.
> {code}
> final String multiPut = "--multiPut=";
>       if (cmd.startsWith(multiPut)) {
>         opts.multiPut = Integer.parseInt(cmd.substring(multiPut.length()));
>         if (!opts.autoFlush && opts.multiPut > 0) {
>           throw new IllegalArgumentException("autoFlush must be true when multiPut is more than 0");
>         }
>         continue;
>       }
> {code}
> 'autoFlush ' default value is false. If multiPut is specified prior to autoFlush in the PE command, we will end up throwing IllegalArgumentException.
> Checking other validations, seems not having such issue.  Still better to move all the validations together into a private method and call that once the parse is over.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)