You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Joe McDonnell (Code Review)" <ge...@cloudera.org> on 2020/08/06 01:32:07 UTC
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16297
Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS
......................................................................
IMPALA-10043: Keep more logs when using EE_TEST_SHARDS
IMPALA-9887 introduced the EE_TEST_SHARDS setting, which splits
the end-to-end test into shards and restarts Impala in between.
In order to keep the logs from all the shards, the value for
max_log_files needs to be increased so that none get aged out.
This multiplies IMPALA_MAX_LOG_FILES by the number of shards
using EE_TEST_SHARDS.
Testing:
- Ran a test with EE_TEST_SHARDS=6 and verified that the
logs are preserved.
Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88
---
M bin/run-all-tests.sh
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/16297/1
--
To view, visit http://gerrit.cloudera.org:8080/16297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88
Gerrit-Change-Number: 16297
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16297 )
Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6249/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/16297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88
Gerrit-Change-Number: 16297
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Aug 2020 19:16:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16297 )
Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS
......................................................................
IMPALA-10043: Keep more logs when using EE_TEST_SHARDS
IMPALA-9887 introduced the EE_TEST_SHARDS setting, which splits
the end-to-end test into shards and restarts Impala in between.
In order to keep the logs from all the shards, the value for
max_log_files needs to be increased so that none get aged out.
This multiplies IMPALA_MAX_LOG_FILES by the number of shards
using EE_TEST_SHARDS.
Testing:
- Ran a test with EE_TEST_SHARDS=6 and verified that the
logs are preserved.
Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88
Reviewed-on: http://gerrit.cloudera.org:8080/16297
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Laszlo Gaal <la...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 5 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Laszlo Gaal: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/16297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88
Gerrit-Change-Number: 16297
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16297 )
Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88
Gerrit-Change-Number: 16297
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Sat, 08 Aug 2020 00:34:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Posted by "Laszlo Gaal (Code Review)" <ge...@cloudera.org>.
Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/16297 )
Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88
Gerrit-Change-Number: 16297
Gerrit-PatchSet: 2
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Tue, 11 Aug 2020 16:44:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10043: Keep more logs when using EE TEST SHARDS
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16297 )
Change subject: IMPALA-10043: Keep more logs when using EE_TEST_SHARDS
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/6804/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/16297
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie011b892cd2eb1a528012ec5600e72e44f281a88
Gerrit-Change-Number: 16297
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Laszlo Gaal <la...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Aug 2020 01:55:26 +0000
Gerrit-HasComments: No