[GitHub] zabetak commented on a change in pull request #1080: [CALCITE-2887] Improve performance of RelLiteral#toJavaString

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #1080: [CALCITE-2887] Improve performance of RelLiteral#toJavaString
URL: https://github.com/apache/calcite/pull/1080#discussion_r261693775
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/util/Unsafe.java
 ##########
 @@ -49,12 +49,6 @@ public static void clear(StringWriter sw) {
     // Included in this class because StringBuffer is banned.
     sw.getBuffer().setLength(0);
   }
-
-  /** Appends to {@link StringWriter}. */
-  public static void append(StringWriter sw, CharSequence charSequence, int start, int end) {
 
 Review comment:
   I am wondering if I should remove directly the unused (public) method or mark it as deprecated. The class is named Unsafe, and I see no reason why end-users should ever call this method. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services