You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by Zhangshunyu <gi...@git.apache.org> on 2016/12/10 06:11:18 UTC
[GitHub] incubator-carbondata pull request #416: Fix the bug of CarbonExample in spar...
GitHub user Zhangshunyu opened a pull request:
https://github.com/apache/incubator-carbondata/pull/416
Fix the bug of CarbonExample in spark1.5 moudle
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Zhangshunyu/incubator-carbondata carbonexample
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-carbondata/pull/416.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #416
----
commit 784384c1bf87a69da78f35cd87d5ca1c657c2eca
Author: Zhangshunyu <zh...@huawei.com>
Date: 2016-12-10T06:08:09Z
Fix the bug of CarbonExample in spark1.5 moudle
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #416: Fix the bug of CarbonExample in spark1.5 mo...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/416
Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/85/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #416: [CARBONDATA-518]Fix the bug of Carbo...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/416#discussion_r91851006
--- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala ---
@@ -26,11 +28,15 @@ object CarbonExample {
def main(args: Array[String]) {
val cc = ExampleUtils.createCarbonContext("CarbonExample")
val testData = ExampleUtils.currentPath + "/src/main/resources/data.csv"
-
+ val rootPath = new File(this.getClass.getResource("/").getPath
--- End diff --
OK, can you directly get these path parameters from ExampleUtils.scala, and fix all examples accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #416: [CARBONDATA-518]Fix the bug of Carbo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-carbondata/pull/416
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #416: [CARBONDATA-518]Fix the bug of Carbo...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/416#discussion_r91846766
--- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala ---
@@ -26,11 +28,15 @@ object CarbonExample {
def main(args: Array[String]) {
val cc = ExampleUtils.createCarbonContext("CarbonExample")
val testData = ExampleUtils.currentPath + "/src/main/resources/data.csv"
-
+ val rootPath = new File(this.getClass.getResource("/").getPath
--- End diff --
These parameters have been defined in ExampleUtils.scala as below, and also already been added into CarbonProperties during creation CarbonContext.
def currentPath: String = new File(this.getClass.getResource("/").getPath + "../../")
.getCanonicalPath
val storeLocation = currentPath + "/target/store"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #416: [CARBONDATA-518]Fix the bug of CarbonExampl...
Posted by chenliang613 <gi...@git.apache.org>.
Github user chenliang613 commented on the issue:
https://github.com/apache/incubator-carbondata/pull/416
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata pull request #416: [CARBONDATA-518]Fix the bug of Carbo...
Posted by Zhangshunyu <gi...@git.apache.org>.
Github user Zhangshunyu commented on a diff in the pull request:
https://github.com/apache/incubator-carbondata/pull/416#discussion_r91847903
--- Diff: examples/spark/src/main/scala/org/apache/carbondata/examples/CarbonExample.scala ---
@@ -26,11 +28,15 @@ object CarbonExample {
def main(args: Array[String]) {
val cc = ExampleUtils.createCarbonContext("CarbonExample")
val testData = ExampleUtils.currentPath + "/src/main/resources/data.csv"
-
+ val rootPath = new File(this.getClass.getResource("/").getPath
--- End diff --
@chenliang613 Hi liang, now the path is not get from carboncontext, they are got from carbonproperties, the code has been changed by this commit:
https://github.com/apache/incubator-carbondata/commit/f67ec0125247e98d7925866fd3062ee3ddf16e28https://github.com/apache/incubator-carbondata/commit/f67ec0125247e98d7925866fd3062ee3ddf16e28
And you can try carbon example, its not run now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #416: [CARBONDATA-518]Fix the bug of CarbonExampl...
Posted by Zhangshunyu <gi...@git.apache.org>.
Github user Zhangshunyu commented on the issue:
https://github.com/apache/incubator-carbondata/pull/416
@chenliang613 Fixed, pls check.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-carbondata issue #416: [CARBONDATA-518]Fix the bug of CarbonExampl...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/incubator-carbondata/pull/416
Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/100/
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---