You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/23 08:43:21 UTC
[GitHub] [spark] kevincmchen opened a new pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
kevincmchen opened a new pull request #31621:
URL: https://github.com/apache/spark/pull/31621
### What changes were proposed in this pull request?
This is a followup of #31560,
In #31560, we added `JavaSimpleWritableDataSource ` and left some little problems like unused interface `SessionConfigSupport` 、 inconsistent schema between `JavaSimpleWritableDataSource ` and `SimpleWritableDataSource`.
This PR fixes the remaining problems in #31560.
### Why are the changes needed?
1. `SessionConfigSupport` in `JavaSimpleWritableDataSource ` and `SimpleWritableDataSource` is never used, so we don't need to implement in simple writable table data source tests.
2. change the schema of `SimpleWritableDataSource`, to match `TestingV2Source`
### Does this PR introduce _any_ user-facing change?
NO
### How was this patch tested?
existing testsuites
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785198478
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40010/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-788967581
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785156359
Jenkins test this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-788976269
GA passed, merging to master, thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r584716198
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -222,7 +217,7 @@ class CSVDataWriter(fs: FileSystem, file: Path) extends DataWriter[InternalRow]
private val out = fs.create(file)
override def write(record: InternalRow): Unit = {
- out.writeBytes(s"${record.getLong(0)},${record.getLong(1)}\n")
+ out.writeBytes(s"${record.getInt(0)},${record.getInt(1)}\n")
Review comment:
This change just matches the TestingV2Source.schema?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31621:
URL: https://github.com/apache/spark/pull/31621
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevincmchen commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
kevincmchen commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r585305065
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -68,7 +63,7 @@ class SimpleWritableDataSource extends SimpleTableProvider with SessionConfigSup
new CSVReaderFactory(serializableConf)
}
- override def readSchema(): StructType = tableSchema
+ override def readSchema(): StructType = TestingV2Source.schema
Review comment:
yes, it‘s unnecessary to override the function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevincmchen commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
kevincmchen commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r584633253
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -41,11 +41,9 @@ import org.apache.spark.util.SerializableConfiguration
* Each task writes data to `target/_temporary/uniqueId/$jobId-$partitionId-$attemptNumber`.
* Each job moves files from `target/_temporary/uniqueId/` to `target`.
*/
-class SimpleWritableDataSource extends SimpleTableProvider with SessionConfigSupport {
+class SimpleWritableDataSource extends SimpleTableProvider {
Review comment:
yes, i‘ll update it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785239929
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40010/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785239929
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40010/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-789005645
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135668/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevincmchen commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
kevincmchen commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r585305372
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -134,7 +129,7 @@ class SimpleWritableDataSource extends SimpleTableProvider with SessionConfigSup
private val path = options.get("path")
private val conf = SparkContext.getActive.get.hadoopConfiguration
- override def schema(): StructType = tableSchema
+ override def schema(): StructType = TestingV2Source.schema
Review comment:
yes, it‘s unnecessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785175897
**[Test build #135430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135430/testReport)** for PR 31621 at commit [`e252d75`](https://github.com/apache/spark/commit/e252d7561c0b74461dd4d321b55ce043f36946ab).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevincmchen commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
kevincmchen commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r584633253
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -41,11 +41,9 @@ import org.apache.spark.util.SerializableConfiguration
* Each task writes data to `target/_temporary/uniqueId/$jobId-$partitionId-$attemptNumber`.
* Each job moves files from `target/_temporary/uniqueId/` to `target`.
*/
-class SimpleWritableDataSource extends SimpleTableProvider with SessionConfigSupport {
+class SimpleWritableDataSource extends SimpleTableProvider {
Review comment:
yes, i‘ll fix it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-789010703
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40250/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-789010703
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/40250/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785218563
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40010/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r584725127
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -134,7 +129,7 @@ class SimpleWritableDataSource extends SimpleTableProvider with SessionConfigSup
private val path = options.get("path")
private val conf = SparkContext.getActive.get.hadoopConfiguration
- override def schema(): StructType = tableSchema
+ override def schema(): StructType = TestingV2Source.schema
Review comment:
ditto, `SimpleBatchTable.schema` is already `TestingV2Source.schema`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r584484677
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -41,11 +41,9 @@ import org.apache.spark.util.SerializableConfiguration
* Each task writes data to `target/_temporary/uniqueId/$jobId-$partitionId-$attemptNumber`.
* Each job moves files from `target/_temporary/uniqueId/` to `target`.
*/
-class SimpleWritableDataSource extends SimpleTableProvider with SessionConfigSupport {
+class SimpleWritableDataSource extends SimpleTableProvider {
Review comment:
can we extend `TestingV2Source` instead?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r584725620
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -222,7 +217,7 @@ class CSVDataWriter(fs: FileSystem, file: Path) extends DataWriter[InternalRow]
private val out = fs.create(file)
override def write(record: InternalRow): Unit = {
- out.writeBytes(s"${record.getLong(0)},${record.getLong(1)}\n")
+ out.writeBytes(s"${record.getInt(0)},${record.getInt(1)}\n")
Review comment:
Yea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785348162
**[Test build #135430 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135430/testReport)** for PR 31621 at commit [`e252d75`](https://github.com/apache/spark/commit/e252d7561c0b74461dd4d321b55ce043f36946ab).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `public class JavaSimpleWritableDataSource implements TestingV2Source `
* `class SimpleWritableDataSource extends SimpleTableProvider `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-784028696
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] kevincmchen commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
kevincmchen commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r584633253
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -41,11 +41,9 @@ import org.apache.spark.util.SerializableConfiguration
* Each task writes data to `target/_temporary/uniqueId/$jobId-$partitionId-$attemptNumber`.
* Each job moves files from `target/_temporary/uniqueId/` to `target`.
*/
-class SimpleWritableDataSource extends SimpleTableProvider with SessionConfigSupport {
+class SimpleWritableDataSource extends SimpleTableProvider {
Review comment:
yes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785351199
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135430/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785351199
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135430/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-785175897
**[Test build #135430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135430/testReport)** for PR 31621 at commit [`e252d75`](https://github.com/apache/spark/commit/e252d7561c0b74461dd4d321b55ce043f36946ab).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-789010670
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40250/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-789004696
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/40250/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-784028696
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #31621:
URL: https://github.com/apache/spark/pull/31621#discussion_r584724447
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/connector/SimpleWritableDataSource.scala
##########
@@ -68,7 +63,7 @@ class SimpleWritableDataSource extends SimpleTableProvider with SessionConfigSup
new CSVReaderFactory(serializableConf)
}
- override def readSchema(): StructType = tableSchema
+ override def readSchema(): StructType = TestingV2Source.schema
Review comment:
`SimpleScanBuilder.readSchema` is already `TestingV2Source.schema`, we don't need to override it here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31621: [SPARK-34498][SQL][TESTS] fix the remaining problems in #31560
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31621:
URL: https://github.com/apache/spark/pull/31621#issuecomment-789005645
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135668/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org