You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by govind-menon <gi...@git.apache.org> on 2017/12/13 23:06:24 UTC

[GitHub] storm pull request #2456: YSTORM-4457: Fix for wouldFit

GitHub user govind-menon opened a pull request:

    https://github.com/apache/storm/pull/2456

    YSTORM-4457: Fix for wouldFit

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/govind-menon/storm YSTORM-4457-II

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2456
    
----
commit 79b70f65c71c7e489a121ad3b164c474ebe88a0f
Author: Govind Menon <go...@gmail.com>
Date:   2017-12-13T23:05:51Z

    YSTORM-4457: Fix for wouldFit

----


---

[GitHub] storm pull request #2456: STORM-2725: Fix for wouldFit and rebalance as part...

Posted by govind-menon <gi...@git.apache.org>.
GitHub user govind-menon reopened a pull request:

    https://github.com/apache/storm/pull/2456

    STORM-2725: Fix for wouldFit and rebalance as part of GenericResourceAwareScheduling changes

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/govind-menon/storm YSTORM-4457-II

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/storm/pull/2456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2456
    
----
commit 54eed6b86480e3edc3b4d24e36afd9a2e4cb9ded
Author: Govind Menon <go...@gmail.com>
Date:   2017-12-13T23:05:51Z

    STORM-2725: Fix for wouldFit and rebalance

----


---

[GitHub] storm issue #2456: YSTORM-4457: Fix for wouldFit

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2456
  
    Some guidelines for contribution:
    1. Please file an issue to Apache JIRA, rather than referring internal issue.
    2. Please make your title of PR (and summary of JIRA) self-describing. Not only code change is important. Leaving context against the code change is more important for future.


---

[GitHub] storm issue #2456: STORM-2872: Fix for wouldFit and rebalance as part of Gen...

Posted by govind-menon <gi...@git.apache.org>.
Github user govind-menon commented on the issue:

    https://github.com/apache/storm/pull/2456
  
    @HeartSaVioR Done. As an aside the test failure appears to be on the master branch as well.


---

[GitHub] storm issue #2456: STORM-2872: Fix for wouldFit and rebalance as part of Gen...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2456
  
    Thanks for addressing. Please change commit and PR title as well.


---

[GitHub] storm pull request #2456: STORM-2725: Fix for wouldFit and rebalance as part...

Posted by govind-menon <gi...@git.apache.org>.
Github user govind-menon closed the pull request at:

    https://github.com/apache/storm/pull/2456


---

[GitHub] storm pull request #2456: YSTORM-4457: Fix for wouldFit

Posted by kishorvpatil <gi...@git.apache.org>.
Github user kishorvpatil commented on a diff in the pull request:

    https://github.com/apache/storm/pull/2456#discussion_r157072777
  
    --- Diff: storm-server/src/test/java/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java ---
    @@ -640,6 +641,150 @@ public void testHeterogeneousCluster() {
             //end of Test3
         }
     
    +    @Test
    +    public void testHeterogeneousClusterwithGras() {
    --- End diff --
    
    Please refactor to avoid duplicate code.


---

[GitHub] storm issue #2456: STORM-2872: Fix for wouldFit and rebalance as part of Gen...

Posted by govind-menon <gi...@git.apache.org>.
Github user govind-menon commented on the issue:

    https://github.com/apache/storm/pull/2456
  
    @HeartSaVioR apologies for lack of description. I filed a new subtask and added a description


---

[GitHub] storm issue #2456: STORM-2725: Fix for wouldFit and rebalance as part of Gen...

Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:

    https://github.com/apache/storm/pull/2456
  
    I'm sorry but what does "Fix for wouldFit" mean? 
    Please raise a new issue instead of using already-resolved issue.


---

[GitHub] storm pull request #2456: STORM-2872: Fix for wouldFit and rebalance as part...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/storm/pull/2456


---