[jira] Commented: (TUSCANY-709) Loads DataGraph in designated scope(TypeHelper)

["Hasan Muhammad (JIRA)" <tu...@ws.apache.org>]

    [ https://issues.apache.org/jira/browse/TUSCANY-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12472962 ] 

Hasan Muhammad commented on TUSCANY-709:
----------------------------------------

Yang,

The patch looks good. Only one concern. You are using XMLResource.OPTION_EXTENDED_META_DATA for the options map. As i understand that is specifically if the resource is an XMLResource. But that assumption may not be valid, as the resource could be any resource. Also if we look at the code, the resource obtained there is generic type, i.e. just Resource. You may be better off if you use EXTENDED_META_DATA as the key in the options map.

Frank, please correct me if i am wrong.

Hasan

> Loads DataGraph in designated scope(TypeHelper)
> -----------------------------------------------
>
>                 Key: TUSCANY-709
>                 URL: https://issues.apache.org/jira/browse/TUSCANY-709
>             Project: Tuscany
>          Issue Type: Improvement
>          Components: Java SDO Implementation
>    Affects Versions: Java-M2
>            Reporter: Yang ZHONG
>            Priority: Minor
>             Fix For: Java-SDO-Mx
>
>         Attachments: patch.709
>
>
> SDOUtil.loadDataGraph doesn't support scope, this improvement tries to address that.
> TypeHelper#define registers Types with the corresponding TypeHelper instance (scope)
> and XMLHelper#load utilizes the registered Types from the corresponding scope to instantiate DataObject instances.
> Unfortunately yet, current SDOUtil.loadDataGraph
> 2-1. can't designate scope to register serialized Types,
> 2-2. and can't designate scope to utilize already registered Types in order to instantiate user expected DataObject instances.
> An example of 2-1 is SerializeTypesTestCase had to
>         // The following is a kludge to force deserialization of metadata into a different TypeHelper (scope)
>         // TBD figure out a proper non-EMF way to do this.
>         Map options = new HashMap();
>         Object differentFromSerializing = ((TypeHelperImpl) deserializingTypeHelper).getExtendedMetaData();
>         options.put(XMLResource.OPTION_EXTENDED_META_DATA, differentFromSerializing);
> This proposal tries to adress scope by
> 2-1. add new SDOUtil.loadDataGraph(InputStream inputStream,Map options,TypeHelper scope)throws IOException
> 2-2. deprecate old SDOUtil.loadDataGraph(InputStream inputStream,Map options)throws IOException
> Any comment is welcomed.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org