You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/03 18:00:05 UTC
[kudu-CR] [tools] option to control clock source in mini-cluster
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14360
Change subject: [tools] option to control clock source in mini-cluster
......................................................................
[tools] option to control clock source in mini-cluster
Change-Id: I0aedecc328fa87df630d41fb32a6d90ad3b2f8fb
---
M src/kudu/tools/kudu-tool-test.cc
M src/kudu/tools/tool.proto
M src/kudu/tools/tool_action_test.cc
3 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/60/14360/1
--
To view, visit http://gerrit.cloudera.org:8080/14360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0aedecc328fa87df630d41fb32a6d90ad3b2f8fb
Gerrit-Change-Number: 14360
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [tools] option to control clock source in mini-cluster
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14360 )
Change subject: [tools] option to control clock source in mini-cluster
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/14360/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:
http://gerrit.cloudera.org:8080/#/c/14360/1/src/kudu/tools/kudu-tool-test.cc@4425
PS1, Line 4425: INSTANTIATE_TEST_CASE_P(SerializationModes, ControlShellToolTest,
This takes us from 4 to 8 tests, right? That's pretty excessive. I don't really see the point of testing both PB and JSON with Kerberos and built-in NTP. Maybe we can do this instead:
- Parameterize this test on PB/JSON.
- Separate (simpler) test for Kerberos.
- Same for built-in NTP.
So only four tests in total.
--
To view, visit http://gerrit.cloudera.org:8080/14360
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0aedecc328fa87df630d41fb32a6d90ad3b2f8fb
Gerrit-Change-Number: 14360
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 03 Oct 2019 18:20:08 +0000
Gerrit-HasComments: Yes