You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@phoenix.apache.org by st...@apache.org on 2023/12/14 14:08:57 UTC

(phoenix) branch master updated: PHOENIX-7153 Fix Warnings Flagged as Errors by Eclipse

This is an automated email from the ASF dual-hosted git repository.

stoty pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/phoenix.git


The following commit(s) were added to refs/heads/master by this push:
     new 75e085b93c PHOENIX-7153 Fix Warnings Flagged as Errors by Eclipse
75e085b93c is described below

commit 75e085b93c94c8bfff8141dacd9185f09d13e5c3
Author: Istvan Toth <st...@apache.org>
AuthorDate: Thu Dec 14 08:35:55 2023 +0100

    PHOENIX-7153 Fix Warnings Flagged as Errors by Eclipse
---
 .../org/apache/phoenix/expression/RowValueConstructorExpression.java | 2 +-
 .../apache/phoenix/jdbc/ParallelPhoenixNullComparingResultSet.java   | 2 +-
 .../java/org/apache/phoenix/mapreduce/transform/TransformTool.java   | 5 ++---
 3 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/phoenix-core-client/src/main/java/org/apache/phoenix/expression/RowValueConstructorExpression.java b/phoenix-core-client/src/main/java/org/apache/phoenix/expression/RowValueConstructorExpression.java
index f92d1e22cb..e62e8599b6 100644
--- a/phoenix-core-client/src/main/java/org/apache/phoenix/expression/RowValueConstructorExpression.java
+++ b/phoenix-core-client/src/main/java/org/apache/phoenix/expression/RowValueConstructorExpression.java
@@ -121,7 +121,7 @@ public class RowValueConstructorExpression extends BaseCompoundExpression {
     public void write(DataOutput output) throws IOException {
         super.write(output);
         byte[] b = extraFields.toByteArray();
-        output.writeByte((int)(b.length > 0 ? b[0] & 0xff  : 0));
+        output.writeByte((b.length > 0 ? b[0] & 0xff  : 0));
     }
     
     private void init() {
diff --git a/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ParallelPhoenixNullComparingResultSet.java b/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ParallelPhoenixNullComparingResultSet.java
index 58b8b6dbee..ae8ebf3dd7 100644
--- a/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ParallelPhoenixNullComparingResultSet.java
+++ b/phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ParallelPhoenixNullComparingResultSet.java
@@ -128,7 +128,7 @@ public class ParallelPhoenixNullComparingResultSet extends DelegateResultSet imp
                     boolean secondResult;
                     try {
                         secondResult =
-                                (boolean) ParallelPhoenixUtil.INSTANCE.getFutureNoRetry(
+                                ParallelPhoenixUtil.INSTANCE.getFutureNoRetry(
                                     candidateResultPair.getSecond().getCandidate(), context);
                     } catch (Exception e) {
                         LOG.warn(
diff --git a/phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/transform/TransformTool.java b/phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/transform/TransformTool.java
index d9a761a88b..ccaf84cb76 100644
--- a/phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/transform/TransformTool.java
+++ b/phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/transform/TransformTool.java
@@ -711,9 +711,8 @@ public class TransformTool extends Configured implements Tool {
         byte[][] newSplitPoints = null;
         // TODO : if the rowkey changes via transform, we need to create new split points
         try (Table hDataTable =
-                     (Table) pConnection.getQueryServices()
-                             .getTable(oldTable.getPhysicalName().getBytes());
-             org.apache.hadoop.hbase.client.Connection connection =
+                pConnection.getQueryServices().getTable(oldTable.getPhysicalName().getBytes());
+                org.apache.hadoop.hbase.client.Connection connection =
                      HBaseFactoryProvider.getHConnectionFactory().createConnection(configuration)) {
             // Avoid duplicate split keys and remove the empty key
             oldSplitPoints = connection.getRegionLocator(hDataTable.getName()).getStartKeys();