You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Cong Wang <cw...@twopensource.com> on 2015/11/19 21:08:52 UTC

Re: Review Request 39415: Error out when root qdisc already exists

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39415/
-----------------------------------------------------------

(Updated Nov. 19, 2015, 8:08 p.m.)


Review request for mesos, Ian Downes and Jie Yu.


Changes
-------

Rebase


Repository: mesos


Description
-------

When we enable --egress_unique_flow_per_container, we need to install an fq_codel qdisc on root, but if a qdisc already exists on root, we should not continue since it could be not fq_codel at all, so just exit with error.


Diffs (updated)
-----

  src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cc0152ce44e9fa34210efda8a1c4a6374167eab1 

Diff: https://reviews.apache.org/r/39415/diff/


Testing
-------

Manual tests, with a pre-installed HTB qdisc and without.


Thanks,

Cong Wang

Re: Review Request 39415: Error out when root qdisc already exists

Posted by Jie Yu <yu...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39415/#review107270
-----------------------------------------------------------

Ship it!


Ship It!

- Jie Yu


On Nov. 19, 2015, 8:08 p.m., Cong Wang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39415/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 8:08 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When we enable --egress_unique_flow_per_container, we need to install an fq_codel qdisc on root, but if a qdisc already exists on root, we should not continue since it could be not fq_codel at all, so just exit with error.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/port_mapping.cpp cc0152ce44e9fa34210efda8a1c4a6374167eab1 
> 
> Diff: https://reviews.apache.org/r/39415/diff/
> 
> 
> Testing
> -------
> 
> Manual tests, with a pre-installed HTB qdisc and without.
> 
> 
> Thanks,
> 
> Cong Wang
> 
>