You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/08/14 18:07:24 UTC
Review Request 37483: Suppressing "Unregistered executor" status
message.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37483/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Bugs: AURORA-1193
https://issues.apache.org/jira/browse/AURORA-1193
Repository: aurora
Description
-------
Following the proposal in the ticket suppressing only "Unregistered executor" message.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 24a7a2ce0ae2ee4fc8f7e87325997480f2457312
src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 83dcb4b6aedf6932bde54da4eda131d829e94143
Diff: https://reviews.apache.org/r/37483/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37483: Suppressing "Unregistered executor" status
message.
Posted by Maxim Khutornenko <ma...@apache.org>.
> On Aug. 14, 2015, 4:13 p.m., Aurora ReviewBot wrote:
> > Master (76d5a49) is red with this patch.
> > ./build-support/jenkins/build.sh
> >
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:108: 'return' have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:109: 'block rcurly' have incorrect indentation level 4, expected level should be 6.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:131: 'block' child have incorrect indentation level 10, expected level should be 12.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:131: 'method call' child have incorrect indentation level 10, expected level should be 12.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:132: 'block' child have incorrect indentation level 10, expected level should be 12.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:133: 'block rcurly' have incorrect indentation level 8, expected level should be 10.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:171: 'block' child have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:171: 'latch' have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:171: 'method call' child have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:172: 'block' child have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:172: 'return' have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:173: 'block rcurly' have incorrect indentation level 4, expected level should be 6.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:205: 'block' child have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:205: 'latch' have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:205: 'method call' child have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:206: 'block' child have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:206: 'return' have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:207: 'block rcurly' have incorrect indentation level 4, expected level should be 6.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:240: 'block' child have incorrect indentation level 10, expected level should be 12.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:241: 'block rcurly' have incorrect indentation level 8, expected level should be 10.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:247: 'block' child have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:247: 'latch' have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:247: 'method call' child have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:248: 'block' child have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:248: 'return' have incorrect indentation level 6, expected level should be 8.
> > [ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:249: 'block rcurly' have incorrect indentation level 4, expected level should be 6.
> > FAILED
> >
> > FAILURE: Build failed with an exception.
> >
> > * What went wrong:
> > Execution failed for task ':checkstyleTest'.
> > > Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.xml
> >
> > * Try:
> > Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
> >
> > BUILD FAILED
> >
> > Total time: 1 mins 51.406 secs
> >
> >
> > I will refresh this build result if you post a review containing "@ReviewBot retry"
Somehow introducing a new lambda block tripped checkstyle where it did not have problems eariler. Will convert everything back to anonymous classes.
- Maxim
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37483/#review95432
-----------------------------------------------------------
On Aug. 14, 2015, 4:07 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37483/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 4:07 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1193
> https://issues.apache.org/jira/browse/AURORA-1193
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the proposal in the ticket suppressing only "Unregistered executor" message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 24a7a2ce0ae2ee4fc8f7e87325997480f2457312
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 83dcb4b6aedf6932bde54da4eda131d829e94143
>
> Diff: https://reviews.apache.org/r/37483/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37483: Suppressing "Unregistered executor" status
message.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37483/#review95432
-----------------------------------------------------------
Master (76d5a49) is red with this patch.
./build-support/jenkins/build.sh
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:108: 'return' have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:109: 'block rcurly' have incorrect indentation level 4, expected level should be 6.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:131: 'block' child have incorrect indentation level 10, expected level should be 12.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:131: 'method call' child have incorrect indentation level 10, expected level should be 12.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:132: 'block' child have incorrect indentation level 10, expected level should be 12.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:133: 'block rcurly' have incorrect indentation level 8, expected level should be 10.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:171: 'block' child have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:171: 'latch' have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:171: 'method call' child have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:172: 'block' child have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:172: 'return' have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:173: 'block rcurly' have incorrect indentation level 4, expected level should be 6.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:205: 'block' child have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:205: 'latch' have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:205: 'method call' child have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:206: 'block' child have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:206: 'return' have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:207: 'block rcurly' have incorrect indentation level 4, expected level should be 6.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:240: 'block' child have incorrect indentation level 10, expected level should be 12.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:241: 'block rcurly' have incorrect indentation level 8, expected level should be 10.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:247: 'block' child have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:247: 'latch' have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:247: 'method call' child have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:248: 'block' child have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:248: 'return' have incorrect indentation level 6, expected level should be 8.
[ant:checkstyle] /home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java:249: 'block rcurly' have incorrect indentation level 4, expected level should be 6.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleTest'.
> Checkstyle rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/test.xml
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 1 mins 51.406 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 14, 2015, 4:07 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37483/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 4:07 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1193
> https://issues.apache.org/jira/browse/AURORA-1193
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the proposal in the ticket suppressing only "Unregistered executor" message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 24a7a2ce0ae2ee4fc8f7e87325997480f2457312
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 83dcb4b6aedf6932bde54da4eda131d829e94143
>
> Diff: https://reviews.apache.org/r/37483/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37483: Suppressing "Unregistered executor" status
message.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37483/#review95443
-----------------------------------------------------------
Ship it!
Master (76d5a49) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 14, 2015, 4:34 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37483/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 4:34 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1193
> https://issues.apache.org/jira/browse/AURORA-1193
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the proposal in the ticket suppressing only "Unregistered executor" message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 24a7a2ce0ae2ee4fc8f7e87325997480f2457312
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 83dcb4b6aedf6932bde54da4eda131d829e94143
>
> Diff: https://reviews.apache.org/r/37483/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37483: Suppressing "Unregistered executor" status
message.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37483/#review95440
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Aug. 14, 2015, 9:34 a.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37483/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2015, 9:34 a.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Bugs: AURORA-1193
> https://issues.apache.org/jira/browse/AURORA-1193
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Following the proposal in the ticket suppressing only "Unregistered executor" message.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 24a7a2ce0ae2ee4fc8f7e87325997480f2457312
> src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 83dcb4b6aedf6932bde54da4eda131d829e94143
>
> Diff: https://reviews.apache.org/r/37483/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37483: Suppressing "Unregistered executor" status
message.
Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37483/
-----------------------------------------------------------
(Updated Aug. 14, 2015, 4:34 p.m.)
Review request for Aurora and Zameer Manji.
Changes
-------
Converting back from lambdas to make checkstyle happy.
Bugs: AURORA-1193
https://issues.apache.org/jira/browse/AURORA-1193
Repository: aurora
Description
-------
Following the proposal in the ticket suppressing only "Unregistered executor" message.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 24a7a2ce0ae2ee4fc8f7e87325997480f2457312
src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 83dcb4b6aedf6932bde54da4eda131d829e94143
Diff: https://reviews.apache.org/r/37483/diff/
Testing
-------
Thanks,
Maxim Khutornenko