You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by om...@apache.org on 2014/04/09 21:55:34 UTC

svn commit: r1586112 - in /hive/branches/branch-0.13: ./ ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java

Author: omalley
Date: Wed Apr  9 19:55:34 2014
New Revision: 1586112

URL: http://svn.apache.org/r1586112
Log:
HIVE-6818. I forgot to add the comment that Sergey wanted to add as part of the commit.

Modified:
    hive/branches/branch-0.13/   (props changed)
    hive/branches/branch-0.13/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java

Propchange: hive/branches/branch-0.13/
------------------------------------------------------------------------------
  Merged /hive/trunk:r1586110

Modified: hive/branches/branch-0.13/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java
URL: http://svn.apache.org/viewvc/hive/branches/branch-0.13/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java?rev=1586112&r1=1586111&r2=1586112&view=diff
==============================================================================
--- hive/branches/branch-0.13/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java (original)
+++ hive/branches/branch-0.13/ql/src/java/org/apache/hadoop/hive/ql/io/sarg/SearchArgument.java Wed Apr  9 19:55:34 2014
@@ -166,7 +166,12 @@ public interface SearchArgument {
   public TruthValue evaluate(TruthValue[] leaves);
 
   /**
-   * Serialize the SARG as a kyro object and return the base64 strig.
+   * Serialize the SARG as a kyro object and return the base64 string.
+   *
+   * Hive should replace the current XML-based AST serialization for predicate pushdown
+   * with the Kryo serialization of the SARG because the representation is much more
+   * compact and focused on what is needed for predicate pushdown.
+   *
    * @return the serialized SARG
    */
   public String toKryo();