You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/07/22 15:20:51 UTC
[GitHub] [cloudstack] skattoju4 commented on a change in pull request #4219: iscsi session cleanup now configurable, filters iscsi partitions
skattoju4 commented on a change in pull request #4219:
URL: https://github.com/apache/cloudstack/pull/4219#discussion_r458874196
##########
File path: plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java
##########
@@ -1156,9 +1156,15 @@ public boolean configure(final String name, final Map<String, Object> params) th
storageProcessor.configure(name, params);
storageHandler = new StorageSubsystemCommandHandlerBase(storageProcessor);
- IscsiStorageCleanupMonitor isciCleanupMonitor = new IscsiStorageCleanupMonitor();
- final Thread cleanupMonitor = new Thread(isciCleanupMonitor);
- cleanupMonitor.start();
+ boolean _iscsiCleanUpEnabled = (boolean)params.get("iscsi.session.cleanup.enabled");
+
+ if (_iscsiCleanUpEnabled) {
Review comment:
Thanks for pointing this out. I used your approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org