You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by GitBox <gi...@apache.org> on 2023/01/16 16:33:04 UTC
[GitHub] [incubator-pegasus] acelyc111 opened a new pull request, #1314: chore(CI): Add unit test workflow for python client
acelyc111 opened a new pull request, #1314:
URL: https://github.com/apache/incubator-pegasus/pull/1314
https://github.com/apache/incubator-pegasus/issues/1313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan merged pull request #1314: chore(CI): Add unit test workflow for python client
Posted by GitBox <gi...@apache.org>.
empiredan merged PR #1314:
URL: https://github.com/apache/incubator-pegasus/pull/1314
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a diff in pull request #1314: chore(CI): Add unit test workflow for python client
Posted by GitBox <gi...@apache.org>.
Smityz commented on code in PR #1314:
URL: https://github.com/apache/incubator-pegasus/pull/1314#discussion_r1071472295
##########
.github/workflows/test_python-client.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Test - python client
+on:
+ pull_request:
+ branches:
+ - master
+ - 'v[0-9]+.*' # release branch
+ - ci-test # testing branch for github action
+ - '*dev' # developing branch
+ paths:
+ - python-client/**
+
+ workflow_dispatch:
Review Comment:
is it useable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1314: chore(CI): Add unit test workflow for python client
Posted by GitBox <gi...@apache.org>.
acelyc111 commented on code in PR #1314:
URL: https://github.com/apache/incubator-pegasus/pull/1314#discussion_r1071696387
##########
.github/workflows/test_python-client.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Test - python client
+on:
+ pull_request:
+ branches:
+ - master
+ - 'v[0-9]+.*' # release branch
+ - ci-test # testing branch for github action
+ - '*dev' # developing branch
+ paths:
+ - python-client/**
+
+ workflow_dispatch:
Review Comment:
Yes, it is used for manually triggering workflow. For example, you can click the "Run workflow" button on site https://github.com/apache/incubator-pegasus/actions/workflows/lint_and_test_admin-cli_always_pass.yml
##########
.github/workflows/test_python-client.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Test - python client
+on:
+ pull_request:
+ branches:
+ - master
+ - 'v[0-9]+.*' # release branch
+ - ci-test # testing branch for github action
+ - '*dev' # developing branch
+ paths:
+ - python-client/**
+
+ workflow_dispatch:
Review Comment:
@Smityz Yes, it is used for manually triggering workflow. For example, you can click the "Run workflow" button on site https://github.com/apache/incubator-pegasus/actions/workflows/lint_and_test_admin-cli_always_pass.yml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] Smityz commented on a diff in pull request #1314: chore(CI): Add unit test workflow for python client
Posted by GitBox <gi...@apache.org>.
Smityz commented on code in PR #1314:
URL: https://github.com/apache/incubator-pegasus/pull/1314#discussion_r1071698405
##########
.github/workflows/test_python-client.yml:
##########
@@ -0,0 +1,50 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+name: Test - python client
+on:
+ pull_request:
+ branches:
+ - master
+ - 'v[0-9]+.*' # release branch
+ - ci-test # testing branch for github action
+ - '*dev' # developing branch
+ paths:
+ - python-client/**
+
+ workflow_dispatch:
Review Comment:
great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org