You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "Brian Minchau (JIRA)" <xa...@xml.apache.org> on 2005/09/26 08:51:48 UTC
[jira] Created: (XALANJ-2205) If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
------------------------------------------------------------------------
Key: XALANJ-2205
URL: http://issues.apache.org/jira/browse/XALANJ-2205
Project: XalanJ2
Type: Bug
Reporter: Brian Minchau
If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2205) If a URIResolver is provided, don't
call SystemIDResolver.getAbsoluteURI
Posted by "Nicholas Sushkin (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2205?page=comments#action_12445938 ]
Nicholas Sushkin commented on XALANJ-2205:
------------------------------------------
I think there is more work to do than just apply the patch of September 29, 2005. The 2005 patch does not fix org.apache.xalan.xsltc.dom.LoadDocument.java. Please see my comment of 23/May/06.
> If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
> ------------------------------------------------------------------------
>
> Key: XALANJ-2205
> URL: http://issues.apache.org/jira/browse/XALANJ-2205
> Project: XalanJ2
> Issue Type: Bug
> Affects Versions: Latest Development Code, 2.6, 2.7
> Reporter: Brian Minchau
> Assigned To: Brian Minchau
> Fix For: Latest Development Code
>
> Attachments: ProcessorInclude.patch4.txt
>
>
> If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
> The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
> On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2205) If a URIResolver is provided, don't
call SystemIDResolver.getAbsoluteURI
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2205?page=comments#action_12446143 ]
Brian Minchau commented on XALANJ-2205:
---------------------------------------
Nicholas,
please open a separate issue for this. If you have a patch for that fix, or can point to the code that you think needs to be changed that would be great. As you can see right now for the 2.7.1 release coming up we
are focusing on cleaning up issues that have patches attached to them.
With a patch the fix is far more likely to make 2.7.1 (and who knows how long until the next release).
> If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
> ------------------------------------------------------------------------
>
> Key: XALANJ-2205
> URL: http://issues.apache.org/jira/browse/XALANJ-2205
> Project: XalanJ2
> Issue Type: Bug
> Affects Versions: Latest Development Code, 2.6, 2.7
> Reporter: Brian Minchau
> Assigned To: Brian Minchau
> Fix For: Latest Development Code
>
> Attachments: ProcessorInclude.patch4.txt
>
>
> If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
> The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
> On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2205) If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
Posted by "Christine Li (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2205?page=comments#action_12330712 ]
Christine Li commented on XALANJ-2205:
--------------------------------------
The patch looks fine and should resolve the problem. Reviewed by Christine Li
> If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
> ------------------------------------------------------------------------
>
> Key: XALANJ-2205
> URL: http://issues.apache.org/jira/browse/XALANJ-2205
> Project: XalanJ2
> Type: Bug
> Versions: 2.6, 2.7, Latest Development Code
> Reporter: Brian Minchau
> Assignee: Brian Minchau
> Attachments: ProcessorInclude.patch4.txt
>
> If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
> The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
> On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2205) If a URIResolver is provided, don't
call SystemIDResolver.getAbsoluteURI
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2205?page=comments#action_12373118 ]
Brian Minchau commented on XALANJ-2205:
---------------------------------------
Comments from JIRA bug Triage on Febrary 7, 2006:
> Brian needs to apply the patch
> If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
> ------------------------------------------------------------------------
>
> Key: XALANJ-2205
> URL: http://issues.apache.org/jira/browse/XALANJ-2205
> Project: XalanJ2
> Type: Bug
> Versions: 2.6, 2.7, Latest Development Code
> Reporter: Brian Minchau
> Assignee: Brian Minchau
> Attachments: ProcessorInclude.patch4.txt
>
> If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
> The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
> On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2205) If a URIResolver is provided, don't
call SystemIDResolver.getAbsoluteURI
Posted by "Nicholas Sushkin (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2205?page=comments#action_12412953 ]
Nicholas Sushkin commented on XALANJ-2205:
------------------------------------------
You also "blindly use SystemIDResolver" in class org.apache.xalan.xsltc.dom.LoadDocument.
Could you also make that class use user's URIResolver, if it is set.
Thanks.
See
http://svn.apache.org/viewvc/xalan/java/trunk/src/org/apache/xalan/xsltc/dom/LoadDocument.java?view=markup
> If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
> ------------------------------------------------------------------------
>
> Key: XALANJ-2205
> URL: http://issues.apache.org/jira/browse/XALANJ-2205
> Project: XalanJ2
> Type: Bug
> Versions: Latest Development Code, 2.6, 2.7
> Reporter: Brian Minchau
> Assignee: Brian Minchau
> Attachments: ProcessorInclude.patch4.txt
>
> If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
> The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
> On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Resolved: (XALANJ-2205) If a URIResolver is provided, don't
call SystemIDResolver.getAbsoluteURI
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2205?page=all ]
Brian Minchau resolved XALANJ-2205.
-----------------------------------
Fix Version/s: Latest Development Code
Resolution: Fixed
The patch for this fix was applied to the code way back on
September 29, 2005.
> If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
> ------------------------------------------------------------------------
>
> Key: XALANJ-2205
> URL: http://issues.apache.org/jira/browse/XALANJ-2205
> Project: XalanJ2
> Issue Type: Bug
> Affects Versions: Latest Development Code, 2.6, 2.7
> Reporter: Brian Minchau
> Assigned To: Brian Minchau
> Fix For: Latest Development Code
>
> Attachments: ProcessorInclude.patch4.txt
>
>
> If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
> The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
> On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2205) If a URIResolver is provided, don't
call SystemIDResolver.getAbsoluteURI
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2205?page=comments#action_12442920 ]
Brian Minchau commented on XALANJ-2205:
---------------------------------------
Per the JIRA meeting on Oct 16, 2005, with the new remark by Nicholas Sushkin the old patch should be applied and a separate mini-patch should be added to this issue, and then reviewed/approved/applied.
> If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
> ------------------------------------------------------------------------
>
> Key: XALANJ-2205
> URL: http://issues.apache.org/jira/browse/XALANJ-2205
> Project: XalanJ2
> Issue Type: Bug
> Affects Versions: Latest Development Code, 2.6, 2.7
> Reporter: Brian Minchau
> Assigned To: Brian Minchau
> Attachments: ProcessorInclude.patch4.txt
>
>
> If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
> The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
> On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Closed: (XALANJ-2205) If a URIResolver is provided, don't
call SystemIDResolver.getAbsoluteURI
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ https://issues.apache.org/jira/browse/XALANJ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian Minchau closed XALANJ-2205.
---------------------------------
closing this issue.
> If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
> ------------------------------------------------------------------------
>
> Key: XALANJ-2205
> URL: https://issues.apache.org/jira/browse/XALANJ-2205
> Project: XalanJ2
> Issue Type: Bug
> Affects Versions: 2.7
> Reporter: Brian Minchau
> Assignee: Brian Minchau
> Fix For: 2.7.1
>
> Attachments: ProcessorInclude.patch4.txt
>
>
> If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
> The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
> On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2205) If a URIResolver is provided, don't
call SystemIDResolver.getAbsoluteURI
Posted by "Nicholas Sushkin (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2205?page=comments#action_12445946 ]
Nicholas Sushkin commented on XALANJ-2205:
------------------------------------------
In the "document()" function, the same issue is still unresolved. If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI. Would you reopen this bug or should I file it as a separate bug?
Thanks
> If a URIResolver is provided, don't call SystemIDResolver.getAbsoluteURI
> ------------------------------------------------------------------------
>
> Key: XALANJ-2205
> URL: http://issues.apache.org/jira/browse/XALANJ-2205
> Project: XalanJ2
> Issue Type: Bug
> Affects Versions: Latest Development Code, 2.6, 2.7
> Reporter: Brian Minchau
> Assigned To: Brian Minchau
> Fix For: Latest Development Code
>
> Attachments: ProcessorInclude.patch4.txt
>
>
> If the user provides a URIResolver that returns the Source given the absolute URI of the stylesheet module doing the include/import and the relative URI from the href attribute, and if that Source has its system ID set, then there is no reason for the XSLT processor to get involved with the contents of the URIs. The user has provided the full management of stylesheet URIs, to resolve all included/imported Source stylesheet modules and their absolute URIs.
> The URIs are supposed to be legitimate URIs, but wheter or not they actually are should be in the user's control. For example the URIs might be of the form "file:///..." with directories or filenames that have characters in them that are not allowed in legitimate URIs.
> On the other hand, if the user hasn't provided a URIResolver, or that resolver doesn't return a Source, or that Source doesn't have its system ID set, then the fallback of using SystemIDResolver to get the base URI of the included document is OK. If the URIs are not legitimate, the services provided by this class may throw MalformedURIException.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org