You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ross Allen <re...@gmail.com> on 2013/07/05 22:58:43 UTC
Review Request 12284: Correct breadcrumbs for single slave page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/
-----------------------------------------------------------
Review request for mesos.
Repository: mesos
Description
-------
Ending crumb was the host, but it should be the ID of the slave.
Diffs
-----
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
Diff: https://reviews.apache.org/r/12284/diff/
Testing
-------
Thanks,
Ross Allen
Re: Review Request 12284: Correct breadcrumbs for single slave page
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22824
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On July 5, 2013, 10:56 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 10:56 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ending crumb was the host, but it should be the ID of the slave.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Correct breadcrumbs for single slave page
Posted by Ben Mahler <be...@gmail.com>.
> On July 8, 2013, 11:29 p.m., Ben Mahler wrote:
> > Can you attach a screenshot for this one? And what happens with the other slave_*.html pages?
>
> Ross Allen wrote:
> I added pre- and post-commit screenshots. The other slave_*.html pages are unaffected.
Right, this looks good, but now the other slave_*.html pages do _not_ have the SlaveID breadcrumb, can you add it to the other slave_*.html pages as well?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22870
-----------------------------------------------------------
On July 9, 2013, 7:19 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 7:19 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ending crumb was the host, but it should be the ID of the slave.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> File Attachments
> ----------------
>
> Before commit, no ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
> After commit, slave ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Correct breadcrumbs for single slave page
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 8, 2013, 11:29 p.m., Ben Mahler wrote:
> > Can you attach a screenshot for this one? And what happens with the other slave_*.html pages?
I added pre- and post-commit screenshots. The other slave_*.html pages are unaffected.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22870
-----------------------------------------------------------
On July 9, 2013, 7:19 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 7:19 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ending crumb was the host, but it should be the ID of the slave.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> File Attachments
> ----------------
>
> Before commit, no ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
> After commit, slave ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Use slave IDs, not hostnames,
in slave*.html breadcrumbs
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 8, 2013, 11:29 p.m., Ben Mahler wrote:
> > Can you attach a screenshot for this one? And what happens with the other slave_*.html pages?
>
> Ross Allen wrote:
> I added pre- and post-commit screenshots. The other slave_*.html pages are unaffected.
>
> Ben Mahler wrote:
> Right, this looks good, but now the other slave_*.html pages do _not_ have the SlaveID breadcrumb, can you add it to the other slave_*.html pages as well?
That's a good point. I updated the diff to use slave IDs everywhere. Check it out.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22870
-----------------------------------------------------------
On July 9, 2013, 7:18 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 7:18 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The slave was represented by its host, but a slave is uniquely identified by its ID not by its host.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
> src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> File Attachments
> ----------------
>
> Before commit, no ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
> After commit, slave ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Correct breadcrumbs for single slave page
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22870
-----------------------------------------------------------
Can you attach a screenshot for this one? And what happens with the other slave_*.html pages?
- Ben Mahler
On July 5, 2013, 10:56 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 5, 2013, 10:56 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ending crumb was the host, but it should be the ID of the slave.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Use slave IDs, not hostnames,
in slave*.html breadcrumbs
Posted by Ben Mahler <be...@gmail.com>.
> On July 9, 2013, 10:13 p.m., Ben Mahler wrote:
> > Ship It!
Thanks Ross! I trust you've tested out the other pages? If so, I'll go ahead and get this committed for you!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22935
-----------------------------------------------------------
On July 9, 2013, 7:18 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 7:18 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The slave was represented by its host, but a slave is uniquely identified by its ID not by its host.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
> src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> File Attachments
> ----------------
>
> Before commit, no ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
> After commit, slave ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Use slave IDs, not hostnames,
in slave*.html breadcrumbs
Posted by Ben Mahler <be...@gmail.com>.
> On July 9, 2013, 10:13 p.m., Ben Mahler wrote:
> > Ship It!
>
> Ben Mahler wrote:
> Thanks Ross! I trust you've tested out the other pages? If so, I'll go ahead and get this committed for you!
>
> Ross Allen wrote:
> I did, the pages with the changes all render.
committed!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22935
-----------------------------------------------------------
On July 9, 2013, 7:18 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 7:18 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The slave was represented by its host, but a slave is uniquely identified by its ID not by its host.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
> src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> File Attachments
> ----------------
>
> Before commit, no ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
> After commit, slave ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Use slave IDs, not hostnames,
in slave*.html breadcrumbs
Posted by Ross Allen <ro...@mesosphe.re>.
> On July 9, 2013, 10:13 p.m., Ben Mahler wrote:
> > Ship It!
>
> Ben Mahler wrote:
> Thanks Ross! I trust you've tested out the other pages? If so, I'll go ahead and get this committed for you!
I did, the pages with the changes all render.
- Ross
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22935
-----------------------------------------------------------
On July 9, 2013, 7:18 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 7:18 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The slave was represented by its host, but a slave is uniquely identified by its ID not by its host.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
> src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> File Attachments
> ----------------
>
> Before commit, no ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
> After commit, slave ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Use slave IDs, not hostnames,
in slave*.html breadcrumbs
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22935
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On July 9, 2013, 7:18 p.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 7:18 p.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The slave was represented by its host, but a slave is uniquely identified by its ID not by its host.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
> src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
> src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> File Attachments
> ----------------
>
> Before commit, no ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
> After commit, slave ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Use slave IDs, not hostnames,
in slave*.html breadcrumbs
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/
-----------------------------------------------------------
(Updated July 9, 2013, 7:18 p.m.)
Review request for mesos.
Changes
-------
Update all slave*.html pages to represent slaves by their truncated IDs rather than their hosts.
Summary (updated)
-----------------
Use slave IDs, not hostnames, in slave*.html breadcrumbs
Repository: mesos
Description (updated)
-------
The slave was represented by its host, but a slave is uniquely identified by its ID not by its host.
Diffs (updated)
-----
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
src/webui/master/static/slave_executor.html cf3d9567c701f074ba2b1e50467d3fddd3ed5014
src/webui/master/static/slave_framework.html 1a38c65c6febeece1a84716951b82066faa9b8be
Diff: https://reviews.apache.org/r/12284/diff/
Testing
-------
Rendered the "/slaves/:id" route to confirm page renders as expected.
File Attachments
----------------
Before commit, no ID
https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
After commit, slave ID
https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
Thanks,
Ross Allen
Re: Review Request 12284: Correct breadcrumbs for single slave page
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/#review22889
-----------------------------------------------------------
File Attachment: After commit, slave ID - Screen_Shot_2013-07-09_at_12.17.35_AM.png
<https://reviews.apache.org//r/12284/#fcomment4>
slave.html shows a single slave, not a single host. The final breadcrumb should be the slave's ID not the slave's host's name.
- Ross Allen
On July 9, 2013, 7:19 a.m., Ross Allen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/12284/
> -----------------------------------------------------------
>
> (Updated July 9, 2013, 7:19 a.m.)
>
>
> Review request for mesos.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Ending crumb was the host, but it should be the ID of the slave.
>
>
> Diffs
> -----
>
> src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
>
> Diff: https://reviews.apache.org/r/12284/diff/
>
>
> Testing
> -------
>
> Rendered the "/slaves/:id" route to confirm page renders as expected.
>
>
> File Attachments
> ----------------
>
> Before commit, no ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
> After commit, slave ID
> https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
>
>
> Thanks,
>
> Ross Allen
>
>
Re: Review Request 12284: Correct breadcrumbs for single slave page
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/
-----------------------------------------------------------
(Updated July 9, 2013, 7:19 a.m.)
Review request for mesos.
Repository: mesos
Description
-------
Ending crumb was the host, but it should be the ID of the slave.
Diffs
-----
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
Diff: https://reviews.apache.org/r/12284/diff/
Testing
-------
Rendered the "/slaves/:id" route to confirm page renders as expected.
File Attachments (updated)
----------------
Before commit, no ID
https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
After commit, slave ID
https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.17.35_AM.png
Thanks,
Ross Allen
Re: Review Request 12284: Correct breadcrumbs for single slave page
Posted by Ross Allen <ro...@mesosphe.re>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/
-----------------------------------------------------------
(Updated July 9, 2013, 7:19 a.m.)
Review request for mesos.
Repository: mesos
Description
-------
Ending crumb was the host, but it should be the ID of the slave.
Diffs
-----
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
Diff: https://reviews.apache.org/r/12284/diff/
Testing
-------
Rendered the "/slaves/:id" route to confirm page renders as expected.
File Attachments (updated)
----------------
Before commit, no ID
https://reviews.apache.org/media/uploaded/files/2013/07/09/Screen_Shot_2013-07-09_at_12.18.15_AM.png
Thanks,
Ross Allen
Re: Review Request 12284: Correct breadcrumbs for single slave page
Posted by Ross Allen <re...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/12284/
-----------------------------------------------------------
(Updated July 5, 2013, 10:56 p.m.)
Review request for mesos.
Repository: mesos
Description
-------
Ending crumb was the host, but it should be the ID of the slave.
Diffs
-----
src/webui/master/static/slave.html 9a52f907271e362d3dac127fc74e8c4a8581e43d
Diff: https://reviews.apache.org/r/12284/diff/
Testing (updated)
-------
Rendered the "/slaves/:id" route to confirm page renders as expected.
Thanks,
Ross Allen