You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/04/02 22:49:47 UTC

Re: Review Request 19164: Used new optional envmap parameter to subprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19164/
-----------------------------------------------------------

(Updated April 2, 2014, 1:49 p.m.)


Review request for mesos, Ben Mahler and Ian Downes.


Changes
-------

rebased and added dependency


Bugs: MESOS-995
    https://issues.apache.org/jira/browse/MESOS-995


Repository: mesos-git


Description
-------

see summary.


Diffs (updated)
-----

  src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7 
  src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb 

Diff: https://reviews.apache.org/r/19164/diff/


Testing
-------

make check.


Thanks,

Dominic Hamon

Re: Review Request 19164: Used new optional envmap parameter to subprocess.

Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19164/#review39824
-----------------------------------------------------------

Ship it!


Thanks! I'll commit this for you, I've tried to make the commit message a bit more clear.

- Ben Mahler


On April 2, 2014, 10:15 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19164/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 10:15 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Ian Downes.
> 
> 
> Bugs: MESOS-995
>     https://issues.apache.org/jira/browse/MESOS-995
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7 
>   src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb 
> 
> Diff: https://reviews.apache.org/r/19164/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 19164: Used new optional envmap parameter to subprocess.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19164/#review39372
-----------------------------------------------------------


Patch looks great!

Reviews applied: [19164]

All tests passed.

- Mesos ReviewBot


On April 2, 2014, 10:15 p.m., Dominic Hamon wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19164/
> -----------------------------------------------------------
> 
> (Updated April 2, 2014, 10:15 p.m.)
> 
> 
> Review request for mesos, Ben Mahler and Ian Downes.
> 
> 
> Bugs: MESOS-995
>     https://issues.apache.org/jira/browse/MESOS-995
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7 
>   src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb 
> 
> Diff: https://reviews.apache.org/r/19164/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Dominic Hamon
> 
>

Re: Review Request 19164: Used new optional envmap parameter to subprocess.

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19164/
-----------------------------------------------------------

(Updated April 2, 2014, 3:15 p.m.)


Review request for mesos, Ben Mahler and Ian Downes.


Bugs: MESOS-995
    https://issues.apache.org/jira/browse/MESOS-995


Repository: mesos-git


Description
-------

see summary.


Diffs (updated)
-----

  src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7 
  src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb 

Diff: https://reviews.apache.org/r/19164/diff/


Testing
-------

make check.


Thanks,

Dominic Hamon