You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Romain Manni-Bucau <rm...@gmail.com> on 2014/08/08 14:09:46 UTC
removing async annotation finder
Hi guys
I implemented async annotation finder some times ago mainly to avoid
to enable whole feature directly but now on tomee at least we need it
always so I think we'll need to dig why it was slow and fix it.
Wonder if then I can remove this class which works under a particular
environment (needs to be orchestrated from a single thread).
Would it bother you?
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
Re: removing async annotation finder
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Ok, I'm removing it now since I didn't get much feedbacks. And we need
to move ahead.
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-08-08 19:46 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> BTW found another bug: we return a list but a set of the list doesn't
> return the same thing so we surely miss something
>
>
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
>
> 2014-08-08 14:51 GMT+02:00 Jean-Louis MONTEIRO <je...@gmail.com>:
>> nope, it was a workaround more than a feature, but I agree it's time to dig
>> into the real problem.
>>
>>
>> 2014-08-08 14:09 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
>>
>>> Hi guys
>>>
>>> I implemented async annotation finder some times ago mainly to avoid
>>> to enable whole feature directly but now on tomee at least we need it
>>> always so I think we'll need to dig why it was slow and fix it.
>>>
>>> Wonder if then I can remove this class which works under a particular
>>> environment (needs to be orchestrated from a single thread).
>>>
>>> Would it bother you?
>>>
>>>
>>> Romain Manni-Bucau
>>> Twitter: @rmannibucau
>>> Blog: http://rmannibucau.wordpress.com/
>>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>>> Github: https://github.com/rmannibucau
>>
>>
>>
>>
>> --
>> Jean-Louis
Re: removing async annotation finder
Posted by Romain Manni-Bucau <rm...@gmail.com>.
BTW found another bug: we return a list but a set of the list doesn't
return the same thing so we surely miss something
Romain Manni-Bucau
Twitter: @rmannibucau
Blog: http://rmannibucau.wordpress.com/
LinkedIn: http://fr.linkedin.com/in/rmannibucau
Github: https://github.com/rmannibucau
2014-08-08 14:51 GMT+02:00 Jean-Louis MONTEIRO <je...@gmail.com>:
> nope, it was a workaround more than a feature, but I agree it's time to dig
> into the real problem.
>
>
> 2014-08-08 14:09 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
>
>> Hi guys
>>
>> I implemented async annotation finder some times ago mainly to avoid
>> to enable whole feature directly but now on tomee at least we need it
>> always so I think we'll need to dig why it was slow and fix it.
>>
>> Wonder if then I can remove this class which works under a particular
>> environment (needs to be orchestrated from a single thread).
>>
>> Would it bother you?
>>
>>
>> Romain Manni-Bucau
>> Twitter: @rmannibucau
>> Blog: http://rmannibucau.wordpress.com/
>> LinkedIn: http://fr.linkedin.com/in/rmannibucau
>> Github: https://github.com/rmannibucau
>
>
>
>
> --
> Jean-Louis
Re: removing async annotation finder
Posted by Jean-Louis MONTEIRO <je...@gmail.com>.
nope, it was a workaround more than a feature, but I agree it's time to dig
into the real problem.
2014-08-08 14:09 GMT+02:00 Romain Manni-Bucau <rm...@gmail.com>:
> Hi guys
>
> I implemented async annotation finder some times ago mainly to avoid
> to enable whole feature directly but now on tomee at least we need it
> always so I think we'll need to dig why it was slow and fix it.
>
> Wonder if then I can remove this class which works under a particular
> environment (needs to be orchestrated from a single thread).
>
> Would it bother you?
>
>
> Romain Manni-Bucau
> Twitter: @rmannibucau
> Blog: http://rmannibucau.wordpress.com/
> LinkedIn: http://fr.linkedin.com/in/rmannibucau
> Github: https://github.com/rmannibucau
>
--
Jean-Louis