You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2021/09/22 02:20:48 UTC
[Impala-ASF-CR] IMPALA-10922: Fix wrong sarg on ORC Date column in release build
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17861
Change subject: IMPALA-10922: Fix wrong sarg on ORC Date column in release build
......................................................................
IMPALA-10922: Fix wrong sarg on ORC Date column in release build
One line of code is wrapped with DCHECK in generating ORC Date type
literal for predicate pushdown. Release build will ignore all codes
wrapped in DCHECK so that line of logic is missing. This patch fixes it
by moving the code outside of DCHECK.
Tests:
- Reproduced the issue and verified the fix in release build.
Change-Id: Ieda467c822cf5c6f0edc0ddfe4da61c46b04e51f
---
M be/src/exec/hdfs-orc-scanner.cc
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/17861/1
--
To view, visit http://gerrit.cloudera.org:8080/17861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieda467c822cf5c6f0edc0ddfe4da61c46b04e51f
Gerrit-Change-Number: 17861
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10922: Fix wrong sarg on ORC Date column in release build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17861 )
Change subject: IMPALA-10922: Fix wrong sarg on ORC Date column in release build
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieda467c822cf5c6f0edc0ddfe4da61c46b04e51f
Gerrit-Change-Number: 17861
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 20:36:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10922: Fix wrong sarg on ORC Date column in release build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17861 )
Change subject: IMPALA-10922: Fix wrong sarg on ORC Date column in release build
......................................................................
IMPALA-10922: Fix wrong sarg on ORC Date column in release build
One line of code is wrapped with DCHECK in generating ORC Date type
literal for predicate pushdown. Release build will ignore all codes
wrapped in DCHECK so that line of logic is missing. This patch fixes it
by moving the code outside of DCHECK.
Tests:
- Reproduced the issue and verified the fix in release build.
Change-Id: Ieda467c822cf5c6f0edc0ddfe4da61c46b04e51f
Reviewed-on: http://gerrit.cloudera.org:8080/17861
Reviewed-by: Qifan Chen <qc...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exec/hdfs-orc-scanner.cc
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Qifan Chen: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/17861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ieda467c822cf5c6f0edc0ddfe4da61c46b04e51f
Gerrit-Change-Number: 17861
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-10922: Fix wrong sarg on ORC Date column in release build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17861 )
Change subject: IMPALA-10922: Fix wrong sarg on ORC Date column in release build
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7481/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieda467c822cf5c6f0edc0ddfe4da61c46b04e51f
Gerrit-Change-Number: 17861
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 14:26:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10922: Fix wrong sarg on ORC Date column in release build
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17861 )
Change subject: IMPALA-10922: Fix wrong sarg on ORC Date column in release build
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9481/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieda467c822cf5c6f0edc0ddfe4da61c46b04e51f
Gerrit-Change-Number: 17861
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 02:42:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10922: Fix wrong sarg on ORC Date column in release build
Posted by "Qifan Chen (Code Review)" <ge...@cloudera.org>.
Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17861 )
Change subject: IMPALA-10922: Fix wrong sarg on ORC Date column in release build
......................................................................
Patch Set 1: Code-Review+2
Good catch.
--
To view, visit http://gerrit.cloudera.org:8080/17861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieda467c822cf5c6f0edc0ddfe4da61c46b04e51f
Gerrit-Change-Number: 17861
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 14:25:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10922: Fix wrong sarg on ORC Date column in release build
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17861 )
Change subject: IMPALA-10922: Fix wrong sarg on ORC Date column in release build
......................................................................
Patch Set 1:
Verified the RELEASE build: https://jenkins.impala.io/job/pre-review-test/1139/
--
To view, visit http://gerrit.cloudera.org:8080/17861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieda467c822cf5c6f0edc0ddfe4da61c46b04e51f
Gerrit-Change-Number: 17861
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 22 Sep 2021 08:46:23 +0000
Gerrit-HasComments: No