You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/11/20 03:23:35 UTC

[GitHub] [pulsar] liangyepianzhou commented on pull request #18522: [improve][test] Optimize TransactionEndToEndTest

liangyepianzhou commented on PR #18522:
URL: https://github.com/apache/pulsar/pull/18522#issuecomment-1321023896

   > I'm wondering what's the root cause of the `TransactionEndToEndTest` flaky test?
   > 
   > This test failed because of out of time limit (300 seconds), so I guess it was caused by the `receive` with infinite timeout:
   > 
   > https://github.com/apache/pulsar/blob/79d1e5210ea3e30b203f7241180eea1628e9296e/pulsar-broker/src/test/java/org/apache/pulsar/client/impl/TransactionEndToEndTest.java#L163-L167
   > 
   > Could you please explain why changing `sendAsync` to `send` can fix this flaky test?
   
   @labuladong The root cause is the logic of sequence ID and serializeAndSendMessage command not being contained in the same synchronized block. And then make the message drop due to deduplication.
   Https://github.com/apache/pulsar/pull/17836 has already fixed this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org