You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2026/09/22 23:30:00 UTC
[PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
viirya opened a new pull request, #58981:
URL: https://github.com/apache/spark/pull/58981
### What changes were proposed in this pull request?
Construct the non-breaking space test character from its code point and reuse it in the unary trim assertions. This preserves the test inputs and expected results while avoiding Unicode escape sequences in the Scala source.
### Why are the changes needed?
The new trim test on `master` triggers five `nonascii.message` Scalastyle errors. Scalastyle interprets the `\u00A0` escapes as non-ASCII characters, causing Scala lint to fail.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Ran `build/sbt 'catalyst/Test/scalastyle'` successfully: 451 files processed, 0 errors. No new tests were added because the test data and assertions are unchanged.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: Codex (GPT-6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5787878881
Thanks for the quick fix @viirya unblocks some of my own work :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5787844268
Thanks. I am going to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5787869725
Thanks @HyukjinKwon @holdenk
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5802108914
Thanks @uros-b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5787531672
LGTM pending CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "holdenk (via GitHub)" <gi...@apache.org>.
holdenk commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5787532427
cc @uros-b
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya closed pull request #58981: [MINOR][SQL] Avoid Unicode escapes in trim tests
URL: https://github.com/apache/spark/pull/58981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5789048999
Thank you for quick fix, @viirya !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5790418499
Thanks @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5801897495
cc @mkaravel here too, regarding https://github.com/apache/spark/pull/58908
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [MINOR][SQL] Avoid Unicode escapes in trim tests [spark]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #58981:
URL: https://github.com/apache/spark/pull/58981#issuecomment-5787865315
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/e911570da30b60a8943d4cd3bbc489283d48768e
- merged into branch-4.x https://github.com/apache/spark/commit/64c7d7b79c4e708a929f4d4ff5b82aff66d4d27f
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org