You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2020/07/09 06:41:46 UTC
[GitHub] [accumulo] markxiaotao opened a new pull request #1652: Remove an workaround profile exists in core/pom.xml file since the related issue had been already fixed.
markxiaotao opened a new pull request #1652:
URL: https://github.com/apache/accumulo/pull/1652
According to the link https://bugs.eclipse.org/bugs/show_bug.cgi?id=541772#c30, I observed that such issue had already been fixed in 4.12M1 release. The workaround for this profile is not needed in my opinion.
I suggest to remove this profile.
The workaround profile:
https://github.com/apache/accumulo/blob/07bc9d329ea0b8da9a577863acfe009910e189cd/core/pom.xml#L386-L401
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii merged pull request #1652: Remove an workaround profile exists in core/pom.xml file since the related issue had been already fixed.
Posted by GitBox <gi...@apache.org>.
ctubbsii merged pull request #1652:
URL: https://github.com/apache/accumulo/pull/1652
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1652: Remove an workaround profile exists in core/pom.xml file since the related issue had been already fixed.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1652:
URL: https://github.com/apache/accumulo/pull/1652#issuecomment-659596703
Thanks for the PR @markxiaotao ! I merged it, and found and fixed two others of the same type, which would have remained if you hadn't brought it to our attention. Thanks! If you wish to be added as a contributor to https://accumulo.apache.org/people/ , please open a pull request to add yourself at https://github.com/apache/accumulo-website/edit/master/pages/people.md and leave a reference to `apache/accumulo#1652` in your commit log.
If you intend to be a regular contributor to Accumulo projects, please consider subscribing to our developer mailing list (https://accumulo.apache.org/contact-us/) and introducing yourself. :smiley_cat:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] milleruntime commented on pull request #1652: Remove an workaround profile exists in core/pom.xml file since the related issue had been already fixed.
Posted by GitBox <gi...@apache.org>.
milleruntime commented on pull request #1652:
URL: https://github.com/apache/accumulo/pull/1652#issuecomment-658165042
@ctubbsii I believe you ran into this issue in Eclipse. Can you verify this is no longer needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #1652: Remove an workaround profile exists in core/pom.xml file since the related issue had been already fixed.
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on pull request #1652:
URL: https://github.com/apache/accumulo/pull/1652#issuecomment-659143275
@milleruntime I will need to update my Eclipse environment to test it. I will merge it if it is fixed in the current version of Eclipse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org