svn commit: r807282 - /myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java

[mc...@apache.org]

Author: mconcini
Date: Mon Aug 24 15:20:52 2009
New Revision: 807282

URL: http://svn.apache.org/viewvc?rev=807282&view=rev
Log:
quick todo to convert regex pattern to a constant

Modified:
    myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java

Modified: myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java
URL: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java?rev=807282&r1=807281&r2=807282&view=diff
==============================================================================
--- myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java (original)
+++ myfaces/core/trunk/api/src/main/java/javax/faces/webapp/_ErrorPageWriter.java Mon Aug 24 15:20:52 2009
@@ -59,6 +59,8 @@
     private static final String DEBUG_TEMPLATE_RESOURCE = "org.apache.myfaces.DEBUG_TEMPLATE_RESOURCE";
 
     private static String[] DEBUG_PARTS;
+    
+    private static final String REGEX_PATTERN = ".*?\\Q,Id:\\E\\s*(\\S+)\\s*\\].*?";
 
     public _ErrorPageWriter()
     {
@@ -124,8 +126,7 @@
             return null;
 
         List<String> list = new ArrayList<String>();
-        // TODO: Use a constant to reduce the compilation overhaul
-        Pattern pattern = Pattern.compile(".*?\\Q,Id:\\E\\s*(\\S+)\\s*\\].*?");
+        Pattern pattern = Pattern.compile(REGEX_PATTERN);
         Matcher matcher = pattern.matcher(message);
 
         while (matcher.find())