You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "John Russell (Code Review)" <ge...@cloudera.org> on 2017/06/20 21:28:01 UTC
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
John Russell has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7236
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Change-Id: I65495748984268763b2690c193488a338409e13e
---
M docs/topics/impala_known_issues.xml
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/7236/1
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 2:
(1 comment)
Reworded to clarify that size increase is for the topic size, not the metadata itself.
http://gerrit.cloudera.org:8080/#/c/7236/2/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
PS2, Line 572: Impala catalog metadata (table files
: and data blocks)
> This is not correct. IMPALA-4029 causes an increase in catalog update topic
Done
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#3).
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Change-Id: I65495748984268763b2690c193488a338409e13e
---
M docs/topics/impala_known_issues.xml
1 file changed, 25 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/7236/3
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 3: Code-Review+2
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7236/3/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
PS3, Line 572: known
: as <q>topics</q>
remove. statestore topics are not only the catalog updates.
PS3, Line 576: topic
"catalog update topic"
Line 585: until this issue is resolved.
You may want to mention that 'false' is the default value.
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 3:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7236/3/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
PS3, Line 572: known
: as <q>topics</q>
> remove. statestore topics are not only the catalog updates.
Done
PS3, Line 576: topic
> "catalog update topic"
Done
Line 585: until this issue is resolved.
> You may want to mention that 'false' is the default value.
Done
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has uploaded a new patch set (#2).
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Change-Id: I65495748984268763b2690c193488a338409e13e
---
M docs/topics/impala_known_issues.xml
1 file changed, 24 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/7236/2
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7236/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
PS1, Line 572: in memory usage for Impala catalog metadata (table files
: and data blocks). By default, the memory overhead is about 5-7%. If the
: <codeph>compact_catalog_topic</codeph> flag is used, the memory usage is
: more substantial, approximately twice as much as in previous versions.
Increase in memory usage is not the correct description. The effect is increase in catalog update topic size (you have the correct numbers) which results in higher CPU and network utilization when the statestore broadcasts catalog update topics to the impalads.
PS1, Line 578: High
I'd say Medium.
PS1, Line 583: A fix is in the pipeline
IMPALA-5500 is the jira for this fix.
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 4:
Build started: http://jenkins.impala.io:8080/job/gerrit-docs-submit/132/
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Change-Id: I65495748984268763b2690c193488a338409e13e
Reviewed-on: http://gerrit.cloudera.org:8080/7236
Reviewed-by: John Russell <jr...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/topics/impala_known_issues.xml
1 file changed, 26 insertions(+), 0 deletions(-)
Approvals:
Impala Public Jenkins: Verified
John Russell: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 5
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 4: Code-Review+2
Carrying forward +2 from Dimitris.
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 1:
> I included a link to IMPALA-4029 in the description of the known
> issue. Normally if there is a fix pending I'd include a link to
> that. Do we have an upstream JIRA for the patch that will bring the
> memory usage back down?
Yes, there is IMPALA-5500 that will address this issue.
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "Dimitris Tsirogiannis (Code Review)" <ge...@cloudera.org>.
Dimitris Tsirogiannis has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/7236/2/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
PS2, Line 572: Impala catalog metadata (table files
: and data blocks)
This is not correct. IMPALA-4029 causes an increase in catalog update topic size when compact-catalog-topic is used. It doesn't increase catalog metadata in general, it actually has the opposite effect.
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 1:
I included a link to IMPALA-4029 in the description of the known issue. Normally if there is a fix pending I'd include a link to that. Do we have an upstream JIRA for the patch that will bring the memory usage back down?
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
Hello Dimitris Tsirogiannis,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/7236
to look at the new patch set (#4).
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Change-Id: I65495748984268763b2690c193488a338409e13e
---
M docs/topics/impala_known_issues.xml
1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/36/7236/4
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
[Impala-ASF-CR] IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change.
Change subject: IMPALA-4029: [DOCS] Include known issue for 'flat buffers' change
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/7236/1/docs/topics/impala_known_issues.xml
File docs/topics/impala_known_issues.xml:
PS1, Line 572: in memory usage for Impala catalog metadata (table files
: and data blocks). By default, the memory overhead is about 5-7%. If the
: <codeph>compact_catalog_topic</codeph> flag is used, the memory usage is
: more substantial, approximately twice as much as in previous versions.
> Increase in memory usage is not the correct description. The effect is incr
Done
PS1, Line 578: High
> I'd say Medium.
Done
PS1, Line 583: A fix is in the pipeline
> IMPALA-5500 is the jira for this fix.
Done
--
To view, visit http://gerrit.cloudera.org:8080/7236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I65495748984268763b2690c193488a338409e13e
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Dimitris Tsirogiannis <dt...@cloudera.com>
Gerrit-Reviewer: Greg Rahn <gr...@cloudera.com>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-HasComments: Yes