You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by li xu <le...@gmail.com> on 2011/11/16 15:34:28 UTC

Review Request: need to load default features before extended feature

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2851/
-----------------------------------------------------------

Review request for shindig and Henry Saputra.


Summary
-------

Right now extended javascript features is always loaded first than default javascript features.
This is okay for normal case. However if we'd like an extended feature to overwrite an default feature, this would become a problem.
The simple fix would address this issue.


This addresses bug SHINDIG-1661.
    https://issues.apache.org/jira/browse/SHINDIG-1661


Diffs
-----

  /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1202451 

Diff: https://reviews.apache.org/r/2851/diff


Testing
-------

passed junit test.


Thanks,

li

Re: Review Request: need to load default features before extended feature

Posted by Henry Saputra <hs...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2851/#review3305
-----------------------------------------------------------

Ship it!


+1

- Henry


On 2011-11-16 14:34:28, li xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2851/
> -----------------------------------------------------------
> 
> (Updated 2011-11-16 14:34:28)
> 
> 
> Review request for shindig and Henry Saputra.
> 
> 
> Summary
> -------
> 
> Right now extended javascript features is always loaded first than default javascript features.
> This is okay for normal case. However if we'd like an extended feature to overwrite an default feature, this would become a problem.
> The simple fix would address this issue.
> 
> 
> This addresses bug SHINDIG-1661.
>     https://issues.apache.org/jira/browse/SHINDIG-1661
> 
> 
> Diffs
> -----
> 
>   /trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/DefaultGuiceModule.java 1202451 
> 
> Diff: https://reviews.apache.org/r/2851/diff
> 
> 
> Testing
> -------
> 
> passed junit test.
> 
> 
> Thanks,
> 
> li
> 
>