You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by mi...@apache.org on 2023/10/19 13:06:17 UTC

[superset] 09/09: fix(dremio): Fixes issue with Dremio SQL generation for Charts with Series Limit (#25657)

This is an automated email from the ASF dual-hosted git repository.

michaelsmolina pushed a commit to branch 3.0
in repository https://gitbox.apache.org/repos/asf/superset.git

commit 293568ad5ac10d34cc59e66afe936a1cb02ab48f
Author: OskarNS <so...@gmail.com>
AuthorDate: Wed Oct 18 21:54:27 2023 +0200

    fix(dremio): Fixes issue with Dremio SQL generation for Charts with Series Limit (#25657)
    
    (cherry picked from commit be8265794059d8bbe216a4cb22c7a3f6adf4bcb3)
---
 superset/db_engine_specs/dremio.py | 2 --
 superset/views/sql_lab/views.py    | 2 +-
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/superset/db_engine_specs/dremio.py b/superset/db_engine_specs/dremio.py
index 2288c52572..c96159f1b8 100644
--- a/superset/db_engine_specs/dremio.py
+++ b/superset/db_engine_specs/dremio.py
@@ -27,8 +27,6 @@ class DremioEngineSpec(BaseEngineSpec):
     engine = "dremio"
     engine_name = "Dremio"
 
-    allows_alias_in_select = False
-
     _time_grain_expressions = {
         None: "{col}",
         TimeGrain.SECOND: "DATE_TRUNC('second', {col})",
diff --git a/superset/views/sql_lab/views.py b/superset/views/sql_lab/views.py
index 08394eb2ba..068888353c 100644
--- a/superset/views/sql_lab/views.py
+++ b/superset/views/sql_lab/views.py
@@ -214,7 +214,7 @@ class TabStateView(BaseSupersetView):
 
     @has_access_api
     @expose("<int:tab_state_id>", methods=("PUT",))
-    def put(self, tab_state_id: int) -> FlaskResponse:  # pylint: disable=no-self-use
+    def put(self, tab_state_id: int) -> FlaskResponse:
         if _get_owner_id(tab_state_id) != get_user_id():
             return Response(status=403)