You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "jkbkupczyk (via GitHub)" <gi...@apache.org> on 2023/07/20 20:16:41 UTC
[GitHub] [commons-net] jkbkupczyk opened a new pull request, #166: Add IMAP package tests, include junit-jupiter-params artifact
jkbkupczyk opened a new pull request, #166:
URL: https://github.com/apache/commons-net/pull/166
- Adds [junit-jupiter-params](https://mvnrepository.com/artifact/org.junit.jupiter/junit-jupiter-params) artifact
- Adds tests for various IMAP package classes that do not require a real (or mock) IMAP server
- Refactored IMAPReplyTest to use [ParameterizedTest](https://junit.org/junit5/docs/current/user-guide/#writing-tests-parameterized-tests)
FYI @garydgregory @sebbASF @kinow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory merged pull request #166: Add IMAP package tests, include junit-jupiter-params artifact
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory merged PR #166:
URL: https://github.com/apache/commons-net/pull/166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] jkbkupczyk commented on a diff in pull request #166: Add IMAP package tests, include junit-jupiter-params artifact
Posted by "jkbkupczyk (via GitHub)" <gi...@apache.org>.
jkbkupczyk commented on code in PR #166:
URL: https://github.com/apache/commons-net/pull/166#discussion_r1269939305
##########
src/main/java/org/apache/commons/net/imap/IMAPCommand.java:
##########
@@ -84,7 +84,7 @@ public static final String getCommand(final IMAPCommand command) {
}
/**
- * Get the IMAP protocol string command for this command
+ * Returns the IMAP protocol string command for this command
Review Comment:
Got it, will use "Gets ..." in the future 😀
##########
src/main/java/org/apache/commons/net/imap/IMAPCommand.java:
##########
@@ -84,7 +84,7 @@ public static final String getCommand(final IMAPCommand command) {
}
/**
- * Get the IMAP protocol string command for this command
+ * Returns the IMAP protocol string command for this command
Review Comment:
Got it, will use "Gets ..." in the future 😀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [commons-net] garydgregory commented on a diff in pull request #166: Add IMAP package tests, include junit-jupiter-params artifact
Posted by "garydgregory (via GitHub)" <gi...@apache.org>.
garydgregory commented on code in PR #166:
URL: https://github.com/apache/commons-net/pull/166#discussion_r1269933342
##########
src/main/java/org/apache/commons/net/imap/IMAPCommand.java:
##########
@@ -84,7 +84,7 @@ public static final String getCommand(final IMAPCommand command) {
}
/**
- * Get the IMAP protocol string command for this command
+ * Returns the IMAP protocol string command for this command
Review Comment:
I usually normalize Javadoc comments for getters to "Gets..." in all of Commons, so let's keep going in that direction IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org