[GitHub] [superset] mayurnewase commented on issue #12681: [chart]Pivot Table Rendering Superset 1.0

[GitBox <gi...@apache.org>]

mayurnewase commented on issue #12681:
URL: https://github.com/apache/superset/issues/12681#issuecomment-777209747


   Hi @lilila thanks for raising this.
   I have raised pr to handle image rendering,but I think setting escape to False might not be a good idea, so you might need to continue doing it manually.
   
   To display text with links would be bit difficult to handle as it will require html parsing and finding correct text inside and setting it seperately along with innerHtml property.
   If this is absolute requirement it can be done at the cost of number,date,null formatting,by applying following patch in superset-ui repository and linking that plugin to main repo.
   
   ```
   diff --git a/plugins/legacy-plugin-chart-pivot-table/src/PivotTable.js b/plugins/legacy-plugin-chart-pivot-table/src/PivotTable.js
   index ec822dbc..97cd62e9 100644
   --- a/plugins/legacy-plugin-chart-pivot-table/src/PivotTable.js
   +++ b/plugins/legacy-plugin-chart-pivot-table/src/PivotTable.js
   @@ -117,7 +117,7 @@ function PivotTable(element, props) {
                dateRegex,
                dateFormatter,
              );
   -          $(this)[0].textContent = textContent;
   +          //$(this)[0].textContent = textContent;
              $(this).attr = attr;
            }        
          });
   
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org