[GitHub] [spark] HeartSaVioR commented on a change in pull request #31572: [SPARK-34446][SS][DOCS] Update doc for stream-stream join (full outer + left semi)

[GitBox <gi...@apache.org>]

HeartSaVioR commented on a change in pull request #31572:
URL: https://github.com/apache/spark/pull/31572#discussion_r577142009



##########
File path: docs/structured-streaming-programming-guide.md
##########
@@ -1337,7 +1337,7 @@ impressionsWithWatermark.join(
     clickTime >= impressionTime AND
     clickTime <= impressionTime + interval 1 hour
     """),
-  joinType = "leftOuter"      // can be "inner", "leftOuter", "rightOuter"
+  joinType = "leftOuter"      // can be "inner", "leftOuter", "rightOuter", "fullOuter", "leftSemi"

Review comment:
       probably the purpose was to enumerate the all possible values for joinType. while I agree it's not matching with the section, I feel it's not a big deal. either is fine, including leaving it as it is (with adding left semi) and another minor PR to fix.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org