[jira] [Commented] (TAJO-610) Refactor Column class

["Hyunsik Choi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TAJO-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13905639#comment-13905639 ] 

Hyunsik Choi commented on TAJO-610:
-----------------------------------

Created a review request against branch master in reviewboard 
https://reviews.apache.org/r/18274/


> Refactor Column class
> ---------------------
>
>                 Key: TAJO-610
>                 URL: https://issues.apache.org/jira/browse/TAJO-610
>             Project: Tajo
>          Issue Type: Bug
>          Components: catalog
>            Reporter: Hyunsik Choi
>            Assignee: Hyunsik Choi
>             Fix For: 0.8-incubating
>
>         Attachments: TAJO-610.patch
>
>
> Column class has some ambiguous methods and some complex logics.
> This patch simplifies and refactors Column class as follows:
>  * Rename getColumnNum() to size()
>  * Remove qualifier variable from Column and ColumnProto
>  * Rename getColumnName to getSimpleName
>  * Move some codes for qualification and simple name to CatalogUtil and refactor them for common identifiers including database, table and column names
>  * Change Column as an immutable object



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)