You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "yihua (via GitHub)" <gi...@apache.org> on 2026/01/07 03:08:12 UTC

[PR] test: Fix flaky test in TestHoodieClientMultiWriter [hudi]

yihua opened a new pull request, #17793:
URL: https://github.com/apache/hudi/pull/17793

   ### Describe the issue this Pull Request addresses
   
   The test `TestHoodieClientMultiWriter#testMultiWriterWithInsertsToDistinctPartitions` uses hardcoded sequential instant times ("002", "003", "004", "005", "006") for 5 concurrent writers. Since the writers ran concurrently without coordination, there was no guarantee they would start and complete in order. If writer "004" started first, subsequent attempts would create "002" or "003", which is not realistic.
   
   ### Summary and Changelog
   
   This PR fixes the test to use `InProcessTimeGenerator.createNewInstantTime()` for the each commit.
   
   ### Impact
   
   Test improvement.
   
   ### Risk Level
   
   none
   
   ### Documentation Update
   
   none
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Enough context is provided in the sections above
   - [ ] Adequate tests were added if applicable
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: Fix flaky test in TestHoodieClientMultiWriter [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17793:
URL: https://github.com/apache/hudi/pull/17793#issuecomment-3717154250

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5f3f35666123cc89cab2b073b8920958b35f5a3b",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10826",
       "triggerID" : "5f3f35666123cc89cab2b073b8920958b35f5a3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5f3f35666123cc89cab2b073b8920958b35f5a3b Azure: [PENDING](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10826) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: Fix flaky test in TestHoodieClientMultiWriter [hudi]

Posted by "voonhous (via GitHub)" <gi...@apache.org>.
voonhous merged PR #17793:
URL: https://github.com/apache/hudi/pull/17793


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: Fix flaky test in TestHoodieClientMultiWriter [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17793:
URL: https://github.com/apache/hudi/pull/17793#issuecomment-3717352108

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5f3f35666123cc89cab2b073b8920958b35f5a3b",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10826",
       "triggerID" : "5f3f35666123cc89cab2b073b8920958b35f5a3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5f3f35666123cc89cab2b073b8920958b35f5a3b Azure: [SUCCESS](https://dev.azure.com/apachehudi/a1a51da7-8592-47d4-88dc-fd67bed336bb/_build/results?buildId=10826) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] test: Fix flaky test in TestHoodieClientMultiWriter [hudi]

Posted by "hudi-bot (via GitHub)" <gi...@apache.org>.
hudi-bot commented on PR #17793:
URL: https://github.com/apache/hudi/pull/17793#issuecomment-3717151021

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "5f3f35666123cc89cab2b073b8920958b35f5a3b",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "5f3f35666123cc89cab2b073b8920958b35f5a3b",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 5f3f35666123cc89cab2b073b8920958b35f5a3b UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org